test: Close client on teardown - #7562
Merged
alexander-alderman-webb merged 1 commit intoSep 22, 2026
Merged
Conversation
alexander-alderman-webb
marked this pull request as ready for review
September 22, 2026 06:41
Contributor
Codecov Results 📊✅ 129634 passed | ⏭️ 7148 skipped | Total: 136782 | Pass Rate: 94.77% | Execution Time: 451m 50s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2550 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.20% 90.19% -0.01%
==========================================
Files 194 194 —
Lines 25888 25994 +106
Branches 9584 9660 +76
==========================================
+ Hits 23352 23444 +92
- Misses 2536 2550 +14
- Partials 1455 1451 -4Generated by Codecov Action |
sentrivana
approved these changes
Sep 22, 2026
alexander-alderman-webb
deleted the
webb/mistral/close-client-on-teardown
branch
September 22, 2026 08:49
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve Mistral test flake involving import race by closing old clients (preventing dangling threads).
Issues
Closes #7556
Reminders
uv run ruff.feat:,fix:,ref:,meta:)