Skip to content

test: Close client on teardown - #7562

Merged
alexander-alderman-webb merged 1 commit into
masterfrom
webb/mistral/close-client-on-teardown
Sep 22, 2026
Merged

alexander-alderman-webb merged 1 commit into
masterfrom
webb/mistral/close-client-on-teardown

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Description

Resolve Mistral test flake involving import race by closing old clients (preventing dangling threads).

Issues

Closes #7556

Reminders

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 22, 2026 06:41
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 22, 2026 06:41
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

129634 passed | ⏭️ 7148 skipped | Total: 136782 | Pass Rate: 94.77% | Execution Time: 451m 50s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +256
Passed Tests 📈 +256
Failed Tests
Skipped Tests

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2550 uncovered lines.
❌ Project coverage is 90.19%. Comparing base (b454d7d) to head (6ec87ee).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.20%    90.19%    -0.01%
==========================================
  Files          194       194         —
  Lines        25888     25994      +106
  Branches      9584      9660       +76
==========================================
+ Hits         23352     23444       +92
- Misses        2536      2550       +14
- Partials      1455      1451        -4

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb merged commit 045d2c1 into master Sep 22, 2026
166 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/mistral/close-client-on-teardown branch September 22, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeyError Flake in CI

2 participants