ref(openai-agents): Deduplicate request model lookup - #7461
Closed
tiagovilasboas wants to merge 1 commit into
Closed
tiagovilasboas wants to merge 1 commit into
tiagovilasboas wants to merge 1 commit into
Conversation
Author
|
Hi — first-time contributor here. Could a maintainer please approve and run the pending workflows when you have a moment? Thanks! |
tiagovilasboas
marked this pull request as ready for review
September 10, 2026 23:27
Extract shared agent/request model resolution into one helper and reuse it from the AI client span and agent-data call sites. Co-authored-by: Tiago Vilas Boas <tcarvalhovb@gmail.com>
cursor
Bot
force-pushed
the
cursor/dedupe-openai-agents-model-830c
branch
from
September 15, 2026 19:29
e8161c5 to
a6eee82
Compare
Contributor
|
Closing this because we won't set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The openai-agents integration resolved the request model name in two places (
spans/ai_client.pyandutils.py) with the same precedence:agent.model(Model instance or string) over_sentry_request_model.This extracts that lookup into
_get_request_model_name()and uses it from both call sites so the precedence cannot drift. Scope is dedupe only — no intended behavior change.Issues
openai-agents#6415Reminders
uv run ruff.feat:,fix:,ref:,meta:)