Skip to content

ref(scopes): Rename sentry_capture_event_with_scope => sentry_scope_capture_event#1882

Merged
limbonaut merged 8 commits into
masterfrom
limbonaut/ref/scope-capture-event-rename
Jul 17, 2026
Merged

ref(scopes): Rename sentry_capture_event_with_scope => sentry_scope_capture_event#1882
limbonaut merged 8 commits into
masterfrom
limbonaut/ref/scope-capture-event-rename

Conversation

@limbonaut

@limbonaut limbonaut commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Renames sentry_capture_event_with_scope to sentry_scope_capture_event to match the sentry_scope_capture_x family, with the scope as the first argument. The old name stays as a deprecated forwarder that keeps the original (event, scope) order, so existing callers keep working and get a warning pointing them to the new function.

@jpnurmi

jpnurmi commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

@tustanivsky heads-up: a small deprecation/rename coming. results in nice and consistent sentry_scope_capture_xxx

@limbonaut

limbonaut commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

@jpnurmi should I frame this as a breaking change in the changelog?

@limbonaut

limbonaut commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

I added an inline "Breaking" marker in the changelog, since we have a compatibility forwarder.

Reframed as breaking change.

Under "Deprecations" section now.

@limbonaut
limbonaut requested a review from jpnurmi July 17, 2026 12:10
@jpnurmi

jpnurmi commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

I wouldn't necessarily consider a deprecation breaking (even if it technically can break -Werror builds) as long as the old API remains functional. For example, it would be hard to deprecate APIs planned for removal in the next major version ahead of time if the deprecation itself needed another major release. :)

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.56%. Comparing base (59cb293) to head (2668247).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1882      +/-   ##
==========================================
- Coverage   75.56%   75.56%   -0.01%     
==========================================
  Files          90       90              
  Lines       21188    21191       +3     
  Branches     3764     3764              
==========================================
+ Hits        16010    16012       +2     
- Misses       4350     4353       +3     
+ Partials      828      826       -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@limbonaut
limbonaut merged commit 46aee2b into master Jul 17, 2026
66 of 67 checks passed
@limbonaut
limbonaut deleted the limbonaut/ref/scope-capture-event-rename branch July 17, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants