Skip to content

ref(bundler-plugins)!: Require webpack 5.1 and remove the webpack5 entry point - #24455

Merged
timfish merged 6 commits into
developfrom
claude/gifted-johnson-6ymldh
Sep 20, 2026
Merged

timfish merged 6 commits into
developfrom
claude/gifted-johnson-6ymldh

Conversation

@timfish

@timfish timfish commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

The webpack plugin still carried its webpack 4 era structure: a sentryWebpackPluginFactory that took BannerPlugin/DefinePlugin classes so the same code could serve webpack 4 and 5, a require('webpack') at module load to feed those fallbacks, and a separate webpack5 entry point whose only difference was calling that factory without them. Webpack 4 hasn't been supported for a long time.

The plugin now reads the classes from compiler.webpack only, so the factory and the fallback are gone. compiler.webpack was added in webpack 5.1.0, three days after 5.0.0, so the webpack peer dependency moves to >=5.1.0. With the fallback gone there is nothing left to distinguish @sentry/bundler-plugins/webpack5 from @sentry/bundler-plugins/webpack, so the webpack5 entry point is removed rather than deprecated. Both changes are documented in the v11 migration guide.

Tim Fish and others added 4 commits September 17, 2026 10:41
…try point

The webpack plugin no longer goes through a factory that takes
BannerPlugin/DefinePlugin classes; it reads them from compiler.webpack
and only falls back to the installed webpack module for 5.0.x. The
@sentry/bundler-plugins/webpack5 entry point is now a deprecated alias
of @sentry/bundler-plugins/webpack.
…try point

The webpack plugin no longer goes through a factory that takes
BannerPlugin/DefinePlugin classes as a fallback for webpack < 5.1; it
reads them from compiler.webpack only, so the webpack peer dependency
is now >=5.1.0. The @sentry/bundler-plugins/webpack5 entry point, which
exported the same plugin without that fallback, is removed.
# Conflicts:
#	CHANGELOG.md
#	packages/bundler-plugins/src/webpack/index.ts
#	packages/bundler-plugins/src/webpack/webpack5.ts
#	packages/bundler-plugins/test/webpack/public-api.test.ts
#	packages/bundler-plugins/test/webpack/webpack5.test.ts
@timfish
timfish marked this pull request as ready for review September 17, 2026 11:16
@timfish
timfish requested a review from chargome September 17, 2026 11:16
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.09 kB - -
@sentry/browser - with treeshaking flags 27.35 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.26 kB - -
@sentry/browser (incl. Tracing) 50.56 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 50.58 kB - -
@sentry/browser (incl. Tracing, Profiling) 53.56 kB - -
@sentry/browser (incl. Tracing, Replay) 90.11 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 79.21 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 94.81 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 107.78 kB - -
@sentry/browser (incl. Feedback) 46.62 kB - -
@sentry/browser (incl. sendFeedback) 34.15 kB - -
@sentry/browser (incl. FeedbackAsync) 39.26 kB - -
@sentry/browser (incl. Metrics) 30.1 kB - -
@sentry/browser (incl. Logs) 30.35 kB - -
@sentry/browser (incl. Metrics & Logs) 31.02 kB - -
@sentry/react 30.84 kB - -
@sentry/react (incl. Tracing) 52.88 kB - -
@sentry/vue 36.34 kB - -
@sentry/vue (incl. Tracing) 52.86 kB - -
@sentry/svelte 29.11 kB - -
CDN Bundle 30.8 kB - -
CDN Bundle (incl. Tracing) 51.1 kB - -
CDN Bundle (incl. Logs, Metrics) 33.06 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 53.09 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 73.75 kB - -
CDN Bundle (incl. Tracing, Replay) 88.66 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 90.58 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 94.7 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 96.71 kB - -
CDN Bundle - uncompressed 91.16 kB - -
CDN Bundle (incl. Tracing) - uncompressed 152.53 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 97.73 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 158.49 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 227.14 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 272.1 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 278.04 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 285.81 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 291.74 kB - -
@sentry/nextjs (client) 55.21 kB - -
@sentry/sveltekit (client) 50.99 kB - -
@sentry/core/server 39.98 kB - -
@sentry/core/browser 13.66 kB - -
@sentry/node 133.34 kB +0.02% +25 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 82.17 kB - -
@sentry/node - without tracing 89.93 kB +0.03% +22 B 🔺
@sentry/node - without channel injection 112.15 kB +0.02% +15 B 🔺
@sentry/aws-serverless 98.19 kB +0.03% +21 B 🔺
@sentry/cloudflare (withSentry) - minified 204.69 kB - -
@sentry/cloudflare (withSentry) 509.25 kB - -

View base workflow run

Comment thread CHANGELOG.md Outdated
timfish and others added 2 commits September 20, 2026 13:32
Co-authored-by: Charly Gomez <charly.gomez1310@gmail.com>
Comment thread packages/bundler-plugins/src/webpack/index.ts
@timfish
timfish merged commit a220d3c into develop Sep 20, 2026
323 of 324 checks passed
@timfish
timfish deleted the claude/gifted-johnson-6ymldh branch September 20, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants