fix(core): Apply byte category rate limits#5716
Merged
Merged
Conversation
… discarded Mirrors the LogByte pattern: records byte-level data category alongside the item-level one when trace metrics are dropped by beforeSendMetrics, queue overflow, or envelope discard. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Contributor
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| abfcc92 | 309.54 ms | 380.32 ms | 70.78 ms |
| 4e3e79d | 328.10 ms | 395.64 ms | 67.54 ms |
| 8c1fb22 | 316.62 ms | 352.78 ms | 36.16 ms |
| b67bb28 | 307.59 ms | 341.24 ms | 33.65 ms |
| d15471f | 361.89 ms | 378.07 ms | 16.18 ms |
| 22f4345 | 313.52 ms | 364.96 ms | 51.44 ms |
| 6727e14 | 337.22 ms | 373.94 ms | 36.71 ms |
| fc5ccaf | 322.49 ms | 405.25 ms | 82.76 ms |
| 22f4345 | 314.79 ms | 375.02 ms | 60.23 ms |
| 2195398 | 319.02 ms | 342.38 ms | 23.36 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| 4e3e79d | 0 B | 0 B | 0 B |
| 8c1fb22 | 0 B | 0 B | 0 B |
| b67bb28 | 0 B | 0 B | 0 B |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 22f4345 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
| 6727e14 | 1.58 MiB | 2.28 MiB | 718.64 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| 22f4345 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
| 2195398 | 0 B | 0 B | 0 B |
Contributor
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
romtsn
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5626.
📜 Description
Apply byte-category rate limits to the corresponding envelope item types. Log envelope items now respect
log_bytelimits, and trace metric envelope items now respecttrace_metric_bytelimits.💡 Motivation and Context
Relay can rate limit logs and trace metrics by both item count and byte size. The SDK already parsed byte-category rate limits, but item filtering only checked
log_itemandtrace_metric, so byte-only limits were stored without dropping the matching envelope item.This change aligns SDK filtering with Relay's count-and-byte rate limit semantics.
💚 How did you test it?
./gradlew :sentry:test --tests "io.sentry.transport.RateLimiterTest"./gradlew spotlessApply apiDump📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps