Conversation
… command Two snippets a new user hits between install and the first event. The tracing verify snippet threw inside `setTimeout(..., 99)`, so the route answered 200 and sent the span, and the throw then fired outside the Nest pipeline. It was captured as `auto.node.onuncaughtexception` and the process exited, leaving the app dead after a single request. Throw synchronously inside the span callback instead, and return it, so Nest handles the error and the span stays part of the request's trace. The snippet showed no controller and no `Sentry` import either, so it now shows both. Rename the span to "My First Test Span", since a span inside the request trace is what arrives. The ESM start command was a package.json fragment that runs nowhere: `"start": "--import ./instrument.mjs nest start"` names no `node` binary and fails with `sh: --: invalid option`. Lead with `NODE_OPTIONS`, which reaches the process that ends up running the app, so `nest start` keeps working. Replace the `npm run start` variant below it with the direct `node --import ./instrument.mjs dist/main.js`, for running the build output. Refs SDK-1499 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
Bot
added
the
Priority: Needs Triage
Contributor
|
Please update the IS YOUR CHANGE URGENT? section of the PR description:
This information helps the Docs team prioritize your review. |
chargome
reviewed
Sep 14, 2026
| }, 99); | ||
| }, | ||
| ); | ||
| return Sentry.startSpan( |
Member
There was a problem hiding this comment.
q: Why do we need this, this shuold be instrumented automatically anyway?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
closes SDK-1499
Two snippets a new user hits between install and the first event.
The tracing verify snippet threw inside
setTimeout(..., 99), so the route answered 200 and sent the span, and the throw then fired outside the Nest pipeline. It was captured asauto.node.onuncaughtexceptionand the process exited, leaving the app dead after a single request. Throw synchronously inside the span callback instead, so Nest handles the error and the span stays part of the request's trace. The snippet also showed no controller and noSentryimport, so it now shows both.The ESM start command was a package.json fragment that runs nowhere:
"start": "--import ./instrument.mjs nest start"names nonodebinary and fails withsh: --: invalid option. Lead withNODE_OPTIONS, which reaches the process that ends up running the app, sonest startkeeps working, and keep the directnode --importform for running the build output.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES