Conversation
- The ESM verify handler closed with `}));`, one `)` too many, so loading the file threw `SyntaxError: Unexpected token ')'` and produced no span. - The `captureAllSettledReasons` example called `Promise.rejected(...)` twice. There is no such method, so it threw `TypeError: Promise.rejected is not a function` before the wrapper could capture anything. The method is `Promise.reject`. - `Sentry.pgIntegration()` and `Sentry.ioredisIntegration()` are not exported. The package re-exports `postgresIntegration` and `redisIntegration` from `@sentry/node`, so the integrations array threw before `Sentry.init` ran. This is the same defect the Google Cloud Functions guide carries. Refs SDK-1518 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
Please update the IS YOUR CHANGE URGENT? section of the PR description:
This information helps the Docs team prioritize your review. |
chargome
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
closes SDK-1518
}));, one)too many, so loading the file threwSyntaxError: Unexpected token ')'and produced no span.captureAllSettledReasonsexample calledPromise.rejected(...)twice. There is no such method, so it threwTypeError: Promise.rejected is not a functionbefore the wrapper could capture anything. The method isPromise.reject.Sentry.pgIntegration()andSentry.ioredisIntegration()are not exported. The package re-exportspostgresIntegrationandredisIntegrationfrom@sentry/node, so the integrations array threw beforeSentry.initran. This is the same defect the Google Cloud Functions guide carries.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES