Skip to content

docs(aws-lambda): Fix three snippets that do not run - #19395

Open
JPeer264 wants to merge 1 commit into
masterfrom
janpeer/sdk-1518-aws-lambda-getting-started-manual-setup
Open

JPeer264 wants to merge 1 commit into
masterfrom
janpeer/sdk-1518-aws-lambda-getting-started-manual-setup

Conversation

@JPeer264

Copy link
Copy Markdown
Member

DESCRIBE YOUR PR

closes SDK-1518

  • The ESM verify handler closed with }));, one ) too many, so loading the file threw SyntaxError: Unexpected token ')' and produced no span.
  • The captureAllSettledReasons example called Promise.rejected(...) twice. There is no such method, so it threw TypeError: Promise.rejected is not a function before the wrapper could capture anything. The method is Promise.reject.
  • Sentry.pgIntegration() and Sentry.ioredisIntegration() are not exported. The package re-exports postgresIntegration and redisIntegration from @sentry/node, so the integrations array threw before Sentry.init ran. This is the same defect the Google Cloud Functions guide carries.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace YYYY-MM-DD with the due date. You can update this information later by editing the PR description.

  • Urgent deadline (GA date, etc.): YYYY-MM-DD
  • Other deadline: YYYY-MM-DD
  • No deadline: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've supplied a deadline.

Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

- The ESM verify handler closed with `}));`, one `)` too many, so loading
  the file threw `SyntaxError: Unexpected token ')'` and produced no span.
- The `captureAllSettledReasons` example called `Promise.rejected(...)`
  twice. There is no such method, so it threw
  `TypeError: Promise.rejected is not a function` before the wrapper
  could capture anything. The method is `Promise.reject`.
- `Sentry.pgIntegration()` and `Sentry.ioredisIntegration()` are not
  exported. The package re-exports `postgresIntegration` and
  `redisIntegration` from `@sentry/node`, so the integrations array threw
  before `Sentry.init` ran. This is the same defect the Google Cloud
  Functions guide carries.

Refs SDK-1518
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@JPeer264
JPeer264 requested review from chargome and msonnb September 14, 2026 10:55
@JPeer264 JPeer264 self-assigned this Sep 14, 2026
@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-docs Error Error Sep 14, 2026 10:55am UTC
1 Skipped Deployment
Project Deployment Actions Updated
develop-docs Ignored Ignored Sep 14, 2026 10:55am UTC

Request Review

@linear-code

linear-code Bot commented Sep 14, 2026

Copy link
Copy Markdown

SDK-1518

@codeowner-assignment
codeowner-assignment Bot requested a review from a team September 14, 2026 10:56
@github-actions github-actions Bot added the Priority: Needs Triage The PR description is missing valid priority information label Sep 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Please update the IS YOUR CHANGE URGENT? section of the PR description:

  • Select exactly one option.
  • If you selected an urgent or other deadline, provide the date as YYYY-MM-DD.

This information helps the Docs team prioritize your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Needs Triage The PR description is missing valid priority information

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants