Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions electron-builder.json5
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,17 @@
"**/*.node"
],
"productName": "Openscreen",
// There is deliberately no `electronVersion` here. electron-builder needs an EXACT
// version because it downloads the binaries for one release, and it takes that from
// package.json's `electron` devDependency, which is pinned without a caret for this
// reason. Setting it here as well would make the version two facts that have to agree,
// and nothing would notice when they stopped.
//
// The error that leads people here is "Electron version ... is a range, not a fixed
// version", raised when the project has no `node_modules/electron` of its own — a git
// worktree, typically, where module resolution finds the parent checkout's copy but
// electron-builder looks only at the project's. The fix is `npm ci` in the worktree, not
// a second declaration of the version.
// Declared rather than left to default BECAUSE the default is package.json's `author` — one
// name, where LICENSE has two holders. Feeds Info.plist's NSHumanReadableCopyright and the
// Windows LegalCopyright, so leaving it implicit put an attribution on the binary that the
Expand Down
10 changes: 2 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@
"@types/react-dom": "^18.3.7",
"@vitejs/plugin-react": "^5.2.0",
"autoprefixer": "^10.5.0",
"electron": "^41.2.1",
"electron": "41.2.1",
"electron-builder": "^26.15.3",
"esbuild": "^0.28.1",
"fast-check": "^4.7.0",
Expand Down
Loading