Preserve OpenAPI 3.1 schema $ref siblings - #1271
Open
abramchikd wants to merge 3 commits into
Open
abramchikd wants to merge 3 commits into
abramchikd wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAPI 3.1 treats Schema Object keywords next to
$refas additional constraints. Previously, kin-openapi decoded these fields but dropped them during serialization and did not apply them consistently after reference resolution.This change preserves schema
$refsiblings across loading, validation, serialization, and reference internalization while keeping the existingSchemaRef.ValueAPI and OpenAPI 3.0 resolution behavior.Changes
Schemarepresentation so they follow the same JSON/YAML round-trip rules as schemas without$ref.allOfconjunct.$refas the reference boundary, avoiding target duplication and recursive marshaling.Compatibility
SchemaRef.Valueremains a non-nil*Schemaafter successful resolution.Schemaserialization.Testing
Added regression coverage for:
$dynamicRef;This pull request was created with the assistance of OpenAI Codex.