fix(pm-desktop): list GitHub App repos via installations - #7
Merged
Conversation
OAuth Connect used GET /user/repos, which often returns [] for org installs even when the app is installed. Walk /user/installations and each installation's repositories instead. A missing or unrefreshable token now surfaces as auth_required, and OAuth status is disconnected when refresh fails, so the UI asks to sign in instead of showing a false empty list / install prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Connect GitHub in pm-desktop listed repos with
GET /user/repos. For GitHub App user tokens (ghu_) that endpoint often returns an empty array for org installs even when DevIntern PM is installed, and the UI treated that as “install the app.”GET /user/installations+GET /user/installations/{id}/repositories(PAT still uses/user/repos)auth_requiredinstead of a successful empty listTest plan
bun run --filter @devintern/pm-desktop testbun run devbuild withGITHUB_OAUTH_CLIENT_IDset/user/repos