Make Connect machine revocation retries idempotent - #3543
Merged
ymichael merged 1 commit intoSep 11, 2026
Merged
Conversation
ymichael
deleted the
bb/fixer-finish-connect-cleanup-after-repeated-revo-thr_f8z86byu8t
branch
September 11, 2026 21:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Connect machine cleanup could become permanently stuck after the remote revocation had already succeeded but its response was lost, or after local grant cleanup failed. On retry, the owned machine row was already revoked and no longer held a label claim, so
revokeMachinereturnednot-foundinstead of acknowledging the completed revocation. The provider retained its local grant and every later retry failed the same way.What changed
How you verified
pnpm exec turbo run test --filter=@bb/web --force -- src/server/api.test.ts: 31/31 passed.pnpm exec turbo run test --filter=bb-plugin-connect --force -- src/server-access.test.ts src/tunnel-lifecycle.test.ts: 20/20 passed.pnpm exec turbo run typecheck build --filter=@bb/web --force: passed.bb plugin build plugins/connect: passed.git diff --checkpassed.Follow-up to #3274.