Manual machine plugin: enroll existing computers - #3275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Users need to enroll an existing computer through the same durable machine flow as other machine providers.
What changed
Adds the built-in manual provider and Existing machine picker inputs, plus production-server lifecycle and transient enrollment-command tests. Closing the creation UI leaves the launch running; explicit cancellation settles it. Includes only its catalog/registration and build-task wiring. This companion should land with the base for backfilled remote machines.
Split from #3231. Depends directly on #3274 (
bb/machine-provider-apis); the GitHub diff contains this integration only. Retarget to main after the base merges.How you verified
Plugin typecheck/lint; server/app bundles with the source CLI; 36 server lifecycle, transcript, and built-in-plugin tests passed.
No live vendor allocation, machine adoption, or Cloud deployment was performed for this split.