Skip to content

Fix catalog identity resolution for installed plugin details - #3273

Open
bb-slop-cop[bot] wants to merge 1 commit into
mainfrom
slopcop/issue-3263
Open

Fix catalog identity resolution for installed plugin details#3273
bb-slop-cop[bot] wants to merge 1 commit into
mainfrom
slopcop/issue-3263

Conversation

@bb-slop-cop

@bb-slop-cop bb-slop-cop Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Human comments

What was wrong

Installed plugin records carry both a catalog entry ID and marketplace name, but the app view model discarded the marketplace name and the detail route selected catalog metadata using only the plugin ID. When two marketplaces used the same ID, the first catalog result supplied another publisher's metadata. The verified investigation is at https://get-bb.github.io/reports/issues/3263.html.

What changed

The app now retains the installed marketplace identity and resolves catalog metadata only when plugin ID, entry ID, and marketplace all match. If the installed catalog entry is unavailable, the detail page uses installed-package metadata instead of an unrelated same-ID result. Uninstalled catalog browsing keeps its existing plugin-ID lookup.

How you verified

  • Added focused route regressions for colliding marketplace entries and for a missing installed catalog entry. Both failed on unchanged origin/main in two clean trusted checkouts, then passed after the fix.
  • pnpm exec turbo run test typecheck --filter=@bb/app (493 test files passed; 4,049 tests passed and 3 skipped)
  • pnpm exec turbo run lint --filter=@bb/app (0 errors; 182 pre-existing warnings)
  • git diff --check
  • Changed-line count: 184 text lines (182 additions, 2 deletions) across 4 files; no binary changes.

Fixes #3263

AGENT GENERATED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installed plugin details use another marketplace's metadata when plugin IDs collide

1 participant