Fix catalog identity resolution for installed plugin details - #3273
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
Fix catalog identity resolution for installed plugin details#3273bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Installed plugin records carry both a catalog entry ID and marketplace name, but the app view model discarded the marketplace name and the detail route selected catalog metadata using only the plugin ID. When two marketplaces used the same ID, the first catalog result supplied another publisher's metadata. The verified investigation is at https://get-bb.github.io/reports/issues/3263.html.
What changed
The app now retains the installed marketplace identity and resolves catalog metadata only when plugin ID, entry ID, and marketplace all match. If the installed catalog entry is unavailable, the detail page uses installed-package metadata instead of an unrelated same-ID result. Uninstalled catalog browsing keeps its existing plugin-ID lookup.
How you verified
origin/mainin two clean trusted checkouts, then passed after the fix.pnpm exec turbo run test typecheck --filter=@bb/app(493 test files passed; 4,049 tests passed and 3 skipped)pnpm exec turbo run lint --filter=@bb/app(0 errors; 182 pre-existing warnings)git diff --checkFixes #3263