Classify Pi edit operations as file updates - #3241
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The Pi delta translator handled edit and write operations in one branch and inferred the file-change kind only from an optional top-level prior-text field. Pi edit batches use nested replacement entries, so the translator emitted an addition for an edit. The behavior and root cause are documented in the reproduction report.
What changed
Pi edit operations now emit update file changes regardless of argument shape. Existing content-only write operations remain additions, and legacy operations with a top-level prior-text field retain their existing update behavior. A focused translator regression covers the nested edit-batch shape.
How you verified
origin/main: expectedupdate, receivedadd.pnpm exec turbo run test typecheck --filter=bb-plugin-provider-pi: 123 tests passed and typecheck passed.pnpm exec oxfmt --check plugins/provider-pi/src/delta-translation.ts plugins/provider-pi/src/delta-translation.test.ts: passed.git diff --check: passed.Fixes #3240