Skip to content

Fix hardwired version numbers in unit tests. Improve test output for failing tests. - #2478

Merged
GernotMaier merged 8 commits into
mainfrom
integration-tests-printout
Aug 27, 2026
Merged

Fix hardwired version numbers in unit tests. Improve test output for failing tests.#2478
GernotMaier merged 8 commits into
mainfrom
integration-tests-printout

Conversation

@GernotMaier

Copy link
Copy Markdown
Contributor

No description provided.

@GernotMaier GernotMaier self-assigned this Aug 27, 2026
@GernotMaier GernotMaier added the Copilot review AI-supported Copilot review label Aug 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates simtools’ dependency-version testing and configuration to avoid hardcoded version expectations, improves pytest failure reporting configuration, and updates integration test configs and the dependency catalog to align with the latest simtools-tests tag.

Changes:

  • Refactor unit tests to derive expected matrix sizes/tags from dependency_versions.yml instead of hardcoding specific versions.
  • Update integration test configs for camera efficiency validation to include an nsb_spectrum input.
  • Bump simtools-tests tag to v0.37.0, add changelog fragments, and adjust pytest reporting flags.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/unit_tests/test_dependency_versions.py Removes hardwired expectations; derives assertions from the loaded catalog for more robust unit tests.
tests/integration_tests/config/validate_camera_efficiency_mstx_nectarcam_north.yml Adds nsb_spectrum input for the integration workflow.
tests/integration_tests/config/validate_camera_efficiency_lstn-02.yml Adds nsb_spectrum input for the integration workflow.
pyproject.toml Adjusts pytest addopts reporting flags to improve visibility into failures.
docs/changes/2478.maintenance.md Adds a changelog fragment for the test maintenance work.
docs/changes/2478.feature.md Adds a changelog fragment noting the simtools-tests version requirement update.
dependency_versions.yml Updates simtools-tests tag from v0.36.0 to v0.37.0.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pyproject.toml Outdated
Comment thread tests/unit_tests/test_dependency_versions.py
GernotMaier and others added 2 commits August 27, 2026 16:33
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ctao-sonarqube

Copy link
Copy Markdown

@GernotMaier

Copy link
Copy Markdown
Contributor Author

Ignoring the failing CORSIKA7 build. That should not have been triggered (will be fixed in #2480 )

@GernotMaier
GernotMaier marked this pull request as ready for review August 27, 2026 15:21
@GernotMaier
GernotMaier merged commit 707368c into main Aug 27, 2026
44 of 64 checks passed
@GernotMaier
GernotMaier deleted the integration-tests-printout branch August 27, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copilot review AI-supported Copilot review

Development

Successfully merging this pull request may close these issues.

2 participants