Minor code cleanups - #1800
Open
Thorium wants to merge 1 commit into
Open
Minor code cleanups#1800Thorium wants to merge 1 commit into
Thorium wants to merge 1 commit into
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor code cleanups.
Copilot generated text-wall:
This pull request introduces several improvements and bug fixes across the codebase, with a focus on more robust type inference, performance and correctness in HTML parsing, and better error handling. The most important changes are summarized below:
HTML Parsing Improvements:
descendantsByfunction inHtmlOperations.fsto use an explicit stack for traversing nodes, improving performance and avoiding stack overflows for deeply nested HTML. The traversal is now pre-order and processes children in document order.hasNamefunction to use a case-insensitive comparison (StringComparison.OrdinalIgnoreCase) for matching node names, ensuring more robust HTML parsing regardless of case.General Robustness and Error Handling:
Helpers.fsby usingString.IsNullOrWhiteSpaceinstead of a manual check, making URI validation more robust and readable.JsonSchema.fsfor invalid reference paths, providing more informative feedback when a reference path does not lead through a record.Type Inference Enhancements:
inferenceModeparameter to theInferColumnTypesmethod inCsvInference.fs, allowing more control over how types are inferred from CSV data.