Enclose moose - #563
Open
MikaeldeVerdier wants to merge 14 commits into
Open
Conversation
…s for both levels and submissions
…ed routing structure; minor improvements to tests
…er submit); added player_submission to InitialRead and score_distribution to UnlockedRead; updated router to match; changed admin_get_all_submissions to admin_get_all_level_submissions; updated and slightly improved tests
…nullable, only shown if player_submission is not None
Contributor
|
How is optimal_is_unique meant to be used by the app? If the allotted number of walls is more than the one used for the optimal solution, the extra walls can be placed by the solver anywhere outside the enclosed area and lead to optimal_is_unique=false even if there's only one way to place the walls which actually enclose the space. Your test grid has only one enclosed area solution, but three wall-solutions: No clue if that messes with the way you wanna build the game in the app. |
Author
|
optimal_is_unique is currently not used by anything. I just added it because it was interesting to see when creating the level. Since optimal_solution only keeps track of one solution, I prefer the solution to be unique (as does enclose.horse). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for enclose.moose. Installed one new package (ortools). Let me know if anything looks weird, don't really know what i'm doing!