Fix crash on \rest when the note completes the bar - #194
Open
FelippeRoza wants to merge 1 commit into
Open
Conversation
note2rest() popped the note off self.bar, but \rest is parsed after the note it applies to, so when that note completed the bar self.bar had already moved to the next one. The note stayed a sounding note, the following bar lost its BarAttr to the pop and gained a stray rest, and merging that bar crashed with IndexError in Bar.inject_voice(). add_to_bar() now records which bar it put an object in, and note2rest() converts the note there. Fixes #147
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example in #147 crashes with
IndexError: list index out of rangeinBar.inject_voice(). Fixes #147.note2rest()popped the note offself.bar, but\restis parsed after the note it applies to, so when that note completed the barself.barhad already moved to the next one. Three things went wrong at once: the note stayed a sounding note, the next bar lost itsBarAttrto thepop(), and it gained a stray rest.add_to_bar()now records which bar it put an object in, andnote2rest()converts the note there. The rest keeps its<display-step>, which is the point of\rest.Note this is the same shape of bug as the chord half of #193, which remembers the bar in
new_chordbase()for the same reason. If both land,chord_barthere could use theobj_baradded here.