fix: resolve peer certificate symbols dynamically on Windows - #645
Merged
fox0430 merged 1 commit intoSep 22, 2026
Merged
Conversation
fox0430
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes compilation with
-d:sslon Windows when using the asyncdispatch backend.std/openssldoes not declareSSL_get_peer_certificateorX509_freeon Windows, so directly calling them prevents dependent projects from
compiling.
This resolves the OpenSSL symbols dynamically instead:
SSL_get1_peer_certificatefor OpenSSL 3SSL_get_peer_certificatefor older OpenSSL versionsX509_freefrom libcryptoThis preserves SCRAM-SHA-256-PLUS channel binding when the installed OpenSSL
library supports it. If the required symbols are genuinely unavailable,
cbPreferfalls back safely andcbRequirecontinues to fail explicitly.Related downstream report:
canermastan/jazzy-framework#33
Validation
Tested on Windows with Nim 2.2.12:
nim check -d:ssl async_postgres.nimnim check tests/test_ssl.nim-d:sslagainst this branch