fix(forge): reset gas snapshot baseline - #16945
Merged
Merged
Conversation
Reset the previous gas sample when starting each snapshot window so gas spent between windows is excluded. Cover repeated identical windows with unrelated work between them.
figtracer
marked this pull request as ready for review
September 19, 2026 21:54
figtracer
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
September 19, 2026 21:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset the gas baseline whenever a snapshot window starts so later
startSnapshotGas/stopSnapshotGaspairs exclude work performed between windows. Add a regression comparing identical back-to-back windows and a third window after unrelated contract creation and storage writes.Fixes #16941.
The implementation, regression test, and PR text were authored with Codex assistance.