Conversation
Read root licenses directly when embedding the VS Code client and staging local VSIX packages. Update the Zed archive recipe to source the same root files so core.symlinks=false cannot package symlink target strings. Check the extracted and packaged license contents in editor CI with Git symlink support disabled.
0xKarl98
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
September 16, 2026 08:46
Contributor
✅ Changelog foundThe deterministic check will validate the changed entry. |
0xKarl98
marked this pull request as draft
September 16, 2026 08:52
0xKarl98
marked this pull request as ready for review
September 16, 2026 09:02
mablr
reviewed
Sep 16, 2026
Comment on lines
+44
to
+49
| - name: Exercise license files without Git symlink support | ||
| run: | | ||
| rm editors/vscode/LICENSE-MIT editors/vscode/LICENSE-APACHE | ||
| git -c core.symlinks=false checkout-index --force -- editors/vscode/LICENSE-MIT editors/vscode/LICENSE-APACHE | ||
| test ! -L editors/vscode/LICENSE-MIT | ||
| test ! -L editors/vscode/LICENSE-APACHE |
Member
There was a problem hiding this comment.
I don't think it's necessary to run in workflow.
Contributor
Author
There was a problem hiding this comment.
Yeah can remove that , just additional but not necessary CI
Comment on lines
+70
to
+80
| - name: Verify VSIX license contents | ||
| run: | | ||
| python3 - <<'PY' | ||
| from pathlib import Path | ||
| from zipfile import ZipFile | ||
|
|
||
| with ZipFile("editors/vscode/bundle/solar-lsp.vsix") as package: | ||
| for name in ("LICENSE-MIT", "LICENSE-APACHE"): | ||
| assert package.read(f"extension/{name}") == Path(name).read_bytes(), name | ||
| assert package.read("extension/syntaxes/LICENSE") == Path("editors/vscode/syntaxes/LICENSE").read_bytes() | ||
| PY |
Remove the dedicated symlink-disabled checkout simulation and VSIX license content check as requested in review. Keep the root license packaging fix and existing Forge license assertions.
Remove the editor license packaging release note as requested. AI assistance: Codex removed the changelog entry and verified the commit scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16730. With
core.symlinks=false, Git checks out editor license symlinks as files containing paths such as../../LICENSE-MIT. Forge and local editor packages then include those paths instead of the full license texts.Forge now embeds both licenses directly from the repository root. VS Code packaging stages the existing package contents with copies of the root licenses before creating the VSIX and removes the temporary staging directory afterward. The Zed archive instructions also read licenses from the repository root. Forge regression coverage compares the extracted license contents with the root files.
This PR requires the
L-ignorechangelog exemption.AI assistance: Codex reviewed the PR, verified the packaging behavior, and removed the changelog entry. This disclosure covers that follow-up work.