fix: remove incorrect truncation of hide file when InParallel#865
Open
jodavies wants to merge 1 commit into
Open
fix: remove incorrect truncation of hide file when InParallel#865jodavies wants to merge 1 commit into
jodavies wants to merge 1 commit into
Conversation
Setting POfull to POfill effectively truncates the hide file, and causes the next read from the HideFile to be taken from the "hole" at the start. Add more info to the HIDEDEBUG debug prints.
|
coverage: 63.158% (+0.01%) from 63.145% — jodavies:issue-856 into form-dev:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #856 , I can't see any reason for the deleted line of code in threads.c to be there.
Does anyone have any idea, or can think of more tests to add?