feat: publish conventional web extension artifacts - #6
Closed
peternhale wants to merge 4 commits into
Closed
Conversation
peternhale
marked this pull request as draft
August 21, 2026 20:18
peternhale
marked this pull request as ready for review
August 24, 2026 12:00
mshanemc
reviewed
Aug 24, 2026
| "request": "launch", | ||
| "args": ["--extensionDevelopmentPath=${workspaceFolder}/lana"], | ||
| "outFiles": ["${workspaceFolder}/lana/out/**/*.js"], | ||
| "outFiles": ["${workspaceFolder}/lana/dist/**/*.js"], |
There was a problem hiding this comment.
is this something we're doing just for us or planning to ship to certinia?
There was a problem hiding this comment.
I wonder if it would be simpler to let CBW config specify the location by extension?
There was a problem hiding this comment.
Collaborator
Author
|
Closing this approach. Code Builder Web can consume the existing out/ artifact via its distDir configuration, so the repository-wide dist/ migration is unnecessary. The standalone VSIX build command is being retained separately on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Code Builder Web expects web-compatible extensions to publish their browser bundle and runtime assets under the conventional
dist/layout. It also filters top-levelout/directories as desktop build waste.What changed
lana/distpnpm build:vsixtarget backed by the local@vscode/vscedependencypnpm serve:weblaunch Chromium interactively throughvscode-test-web, while keeping the port-3001 server headless for Playwright E2EValidation
pnpm lintpnpm test --runInBand— 1,830 testspnpm buildpnpm build:fastpnpm build:vsixpnpm test:e2e:web— VS Code Web E2E passedvscode-test-webCLI supports every interactive launcher option used byserve:web