Deprecate IDP (Identity Provider) login flow - #4151
Merged
Merged
Conversation
Mark the IDP login flow's public API as deprecated (deprecated in 14.0, targeted for removal in 15.0). As Mobile SDK moves to advanced (browser-based) authentication as the default and only auth mechanism, the IDP flow — where one app acts as an identity provider so other service-provider apps log in without their own browser round-trip — is being retired. There is no drop-in replacement; apps should use advanced (browser-based) authentication. This change only adds deprecation annotations. It does not remove the flow or change any runtime behavior — IDP keeps working in 14.0. - SFSDK_DEPRECATED(14.0, 15.0, ...) / @available(*, deprecated) on the public IDP entry points: SalesforceSDKManager (isIdentityProvider, identityProviderURLScheme, loginFlowSelectionViewProvider, idpUserSelectionViewProvider), UserAccountManager IDP members, SPConfig, SFOAuthCoordinator IDP methods, the IDP UI classes, and SFManagedPreferences.idpAppURLScheme. - Internal usages routed around the annotations (non-deprecated sdk_ accessors) and implementations wrapped with -Wdeprecated-implementations pragmas so the SDK still builds warning-clean. Mirrors the useWebServerAuthentication (OAuth user agent flow) deprecation landed the same release.
Clang Static Analysis Issues
Generated by 🚫 Danger |
|
||||||||||||||||||
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (40.54%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #4151 +/- ##
==========================================
- Coverage 70.37% 67.39% -2.99%
==========================================
Files 254 254
Lines 22849 22887 +38
==========================================
- Hits 16080 15424 -656
- Misses 6769 7463 +694
🚀 New features to boost your workflow:
|
|
||||||||||||||||||
sfdctaka
marked this pull request as ready for review
August 28, 2026 00:01
brandonpage
approved these changes
Aug 28, 2026
wmathurin
reviewed
Aug 28, 2026
The -Wdeprecated-implementations suppression pushed before @implementation had no matching pop, so it silenced the warning for the entire file rather than just the implementation block. Add the pop before @EnD to scope it.
wmathurin
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Marks the IDP (Identity Provider) login flow public API as deprecated (deprecated in 14.0, targeted for removal in 15.0).
As Mobile SDK moves to advanced (browser-based) authentication as the default and only auth mechanism, the IDP flow — where one app acts as an identity provider so other "service provider" apps on the device log in without their own browser round-trip — is being retired. There is no drop-in replacement; apps should move to advanced (browser-based) authentication.
This PR only adds deprecation annotations. It does not remove the flow or change any runtime behavior — IDP keeps working in 14.0. App developers now get a compiler deprecation warning one major release ahead of removal.
What changed
SFSDK_DEPRECATED(14.0, 15.0, …)(Obj-C) /@available(*, deprecated, …)(Swift) on the public IDP entry points:SalesforceManager(SalesforceSDKManager):isIdentityProvider,identityProviderURLScheme,loginFlowSelectionViewProvider,idpUserSelectionViewProviderUserAccountManager(SFUserAccountManager): the IDP members (isIdentityProvider,isIDPEnabled,idpAppURIScheme,idpLoginFlowSelectionAction,idpUserSelectionAction, IDP response/command handlers,kickOffIDPInitiatedLoginFlowForSP)SPConfig,SFOAuthCoordinatorIDP methods, the IDP UI classes, andSFManagedPreferences.idpAppURLSchemesdk_-prefixed accessors over the same backing storage), and implementations of the deprecated methods/accessors are wrapped with-Wdeprecated-implementationspragmas — so the SDK still builds warning-clean.Notes
useWebServerAuthentication(OAuth user agent flow) deprecation landed the same release.SalesforceSDKCorebuilds with zero-Wdeprecated-declarations/-Wdeprecated-implementationswarnings.Test
xcodebuild build -scheme SalesforceSDKCore→ BUILD SUCCEEDED, warning-clean for the touched files.