Skip to content

refactor(flow-php/etl): store Floe schema only in the footer#2548

Merged
norberttech merged 3 commits into
1.xfrom
floe-redundant-schema-storage
Jul 25, 2026
Merged

refactor(flow-php/etl): store Floe schema only in the footer#2548
norberttech merged 3 commits into
1.xfrom
floe-redundant-schema-storage

Conversation

@norberttech

Copy link
Copy Markdown
Member

Change Log


Added

Fixed

Changed

  • flow-php/etl - Floe stores its schema only in the footer, dropping the inline SCHEMA frame

Removed

  • flow-php/etl - FloeStreamReader::recover() salvage path

Deprecated

Security

@norberttech norberttech added this to the 0.42.0 milestone Jul 24, 2026
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.41%. Comparing base (4afe11c) to head (6dc2ee5).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##                1.x    #2548    +/-   ##
==========================================
  Coverage     86.40%   86.41%            
- Complexity    23329    23487   +158     
==========================================
  Files          1800     1800            
  Lines         71396    71314    -82     
==========================================
- Hits          61693    61627    -66     
+ Misses         9703     9687    -16     
Components Coverage Δ
etl 90.43% <76.47%> (+0.05%) ⬆️
cli 89.40% <ø> (ø)
lib-array-dot 81.44% <ø> (ø)
lib-azure-sdk 64.44% <ø> (ø)
lib-doctrine-dbal-bulk 93.61% <ø> (ø)
lib-filesystem 86.64% <ø> (ø)
lib-types 91.58% <ø> (ø)
lib-parquet 70.23% <ø> (ø)
lib-parquet-viewer 82.26% <ø> (ø)
lib-snappy 89.82% <ø> (+0.44%) ⬆️
lib-dremel 0.00% <ø> (ø)
lib-postgresql 88.62% <ø> (ø)
lib-telemetry 86.58% <ø> (ø)
bridge-filesystem-async-aws 92.74% <ø> (ø)
bridge-filesystem-azure 90.45% <ø> (ø)
bridge-monolog-http 96.82% <ø> (ø)
bridge-monolog-telemetry 94.79% <ø> (ø)
bridge-openapi-specification 92.07% <ø> (ø)
symfony-http-foundation 78.57% <ø> (ø)
bridge-psr18-telemetry 100.00% <ø> (ø)
bridge-psr3-telemetry 98.95% <ø> (ø)
bridge-psr7-telemetry 100.00% <ø> (ø)
bridge-telemetry-otlp 90.41% <ø> (ø)
bridge-symfony-http-foundation-telemetry 92.85% <ø> (ø)
bridge-symfony-filesystem-bundle 91.85% <ø> (ø)
bridge-symfony-filesystem-cache 98.18% <ø> (ø)
bridge-symfony-postgresql-bundle 93.70% <ø> (ø)
bridge-symfony-postgresql-cache 94.41% <ø> (ø)
bridge-symfony-postgresql-messenger 98.80% <ø> (ø)
bridge-symfony-postgresql-session 93.65% <ø> (ø)
bridge-symfony-telemetry-bundle 90.10% <ø> (ø)
adapter-chartjs 84.05% <ø> (ø)
adapter-csv 89.46% <ø> (ø)
adapter-doctrine 90.75% <ø> (ø)
adapter-google-sheet 91.56% <ø> (ø)
adapter-http 75.79% <ø> (ø)
adapter-json 87.30% <ø> (ø)
adapter-logger 50.00% <ø> (ø)
adapter-parquet 88.69% <ø> (ø)
adapter-text 92.59% <ø> (ø)
adapter-xml 83.56% <ø> (ø)
adapter-avro 0.00% <ø> (ø)
adapter-excel 86.72% <ø> (ø)
adapter-postgresql 90.84% <ø> (ø)
adapter-seal 83.26% <ø> (ø)
bridge-phpunit-postgresql 75.30% <ø> (ø)
bridge-phpunit-telemetry 87.32% <ø> (ø)
bridge-phpstan-types 0.00% <ø> (ø)
bridge-postgresql-valinor 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- drop the inline SCHEMA frame; footer is the sole schema source
- remove FloeStreamReader::recover() salvage path
- update on-disk format docs and encoder parity harness
- wrap footer JSON encoding failure in FloeException
- add missing empty-name guard to enum, html and xml entries
@norberttech
norberttech force-pushed the floe-redundant-schema-storage branch from b71545d to 6dc2ee5 Compare July 25, 2026 10:09
@norberttech
norberttech merged commit 39c700b into 1.x Jul 25, 2026
47 of 48 checks passed
@norberttech
norberttech deleted the floe-redundant-schema-storage branch July 25, 2026 10:29
@github-project-automation github-project-automation Bot moved this from Todo to Done in Roadmap Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant