fix(OSQUERY-003): RegistryType::add() throws std::runtime_error instead of returning Status::failure()

[flamingo]

Closes findings from rule OSQUERY-003 — RegistryType::add() throws std::runtime_error instead of returning Status::failure().

Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.

#	Fix confidence	Finding	Location
1	🟢 90 high	RegistryType::add() throws std::runtime_error instead of returning Status::failure()	osquery/registry/registry_interface.h:253

What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.

---

Run: https://product-hub.flamingo.so/admin/code-review
Run id: 01e7aadc-0204-47ef-b373-fc5dbadf3ab5

Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.

[flamingo]

🦩 What this fix changed, finding by finding

1 finding(s) fixed in this draft — 1 explained inline on the diff.

[flamingo]

🦩 🔴 RegistryType::add() throws std::runtime_error instead of returning Status::failure()

In RegistryType<PluginType>::add() (registry_interface.h), replaced throw std::runtime_error("Cannot add foreign plugin type: " + plugin_name); with return Status::failure("Cannot add foreign plugin type: " + plugin_name);, matching the surrounding Status-based error handling and the suggested fix exactly. No other lines were changed.

🤖 Prompt for AI agents

In osquery/registry/registry_interface.h around line 253, review and complete this code-review fix: RegistryType::add() throws std::runtime_error instead of returning Status::failure().
What the draft fix changed: In `RegistryType<PluginType>::add()` (registry_interface.h), replaced `throw std::runtime_error("Cannot add foreign plugin type: " + plugin_name);` with `return Status::failure("Cannot add foreign plugin type: " + plugin_name);`, matching the surrounding `Status`-based error handling and the suggested fix exactly. No other lines were changed.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟢 90 high — react 👍/👎 to teach the reviewer