fix(OPENFRAM-002-13): Tool installation loop for a machine is not isolated per-tool; one failing install aborts remaining tools

[flamingo]

Closes findings from rule OPENFRAM-002-13 — Tool installation loop for a machine is not isolated per-tool; one failing install aborts remaining tools.

Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.

#	Fix confidence	Finding	Location
1	🟢 90 high	Tool installation loop for a machine is not isolated per-tool; one failing install aborts remaining tools	openframe-client-core/src/main/java/com/openframe/client/service/agentregistration/AgentRegistrationToolInstallationService.java:19

What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.

---

Run: https://product-hub.flamingo.so/admin/code-review
Run id: 59051284-b3d6-4391-892c-38c8737386e1

Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.

[flamingo]

🦩 What this fix changed, finding by finding

1 finding(s) fixed in this draft. (Inline placement was rejected by GitHub for this PR.)

🔴 1. Tool installation loop for a machine is not isolated per-tool; one failing install aborts remaining tools — openframe-client-core/src/main/java/com/openframe/client/service/agentregistration/AgentRegistrationToolInstallationService.java:19
In process(String machineId), wrapped the toolInstallationService.process(machineId, toolAgent) call inside the forEach lambda with a try/catch(Exception e) block that logs the failure via log.error and continues, so one failing tool installation no longer aborts remaining tools for the machine. Matches the suggested fix exactly.

🤖 Prompt for AI agents

In openframe-client-core/src/main/java/com/openframe/client/service/agentregistration/AgentRegistrationToolInstallationService.java around line 19, review and complete this code-review fix: Tool installation loop for a machine is not isolated per-tool; one failing install aborts remaining tools.
What the draft fix changed: In `process(String machineId)`, wrapped the `toolInstallationService.process(machineId, toolAgent)` call inside the `forEach` lambda with a try/catch(Exception e) block that logs the failure via `log.error` and continues, so one failing tool installation no longer aborts remaining tools for the machine. Matches the suggested fix exactly.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟢 90 high — react 👍/👎 to teach the reviewer