-
Notifications
You must be signed in to change notification settings - Fork 0
fix(MESHAGEN-004-2): 28 review findings across 26 files #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
e5a63c3
4c87e54
a04b49a
4f431e8
d43de03
fbfc553
a201eb7
bd4f652
d99c5b5
8ecbf1f
f7e36d2
a4df62d
5ec8bb1
d63238a
2f6c199
59ea8d0
4b703e6
9ee590a
07447a3
e3b5782
50e45f4
db8b4bd
4965aaa
fc063b7
3c5eefe
6b02fad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,19 @@ | ||
| /* | ||
| Copyright 2018 Intel Corporation | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| #include "mac_events.h" | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_events.c is missing the required Apache 2.0 / Intel license header Prepended a standard Apache License 2.0 block comment with the Intel Corporation copyright line at the very top of meshcore/KVM/MacOS/mac_events.c, before the existing π€ Prompt for AI agentsfix confidence: π‘ 85 medium β react π/π to teach the reviewer |
||
| #include <assert.h> | ||
| #include <SystemConfiguration/SystemConfiguration.h> | ||
|
|
@@ -308,3 +324,4 @@ void KeyActionUnicode(uint16_t unicode, int up) | |
| CFRelease(key); | ||
| } | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,26 @@ | ||
| /** | ||
| * @description mac_events.h | ||
| * @author Intel | ||
| * @copyright Intel Corporation 2011 | ||
| * @license Apache-2.0 | ||
| */ | ||
|
|
||
| /* | ||
| Copyright 2011 Intel Corporation | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| /* | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_events.h missing Apache 2.0 license header Added the standard Apache License 2.0 header block (with Intel Corporation 2011 copyright and the canonical http://www.apache.org/licenses/LICENSE-2.0 URL) above the existing "linux_events.h" author comment at the top of meshcore/KVM/MacOS/mac_events.h, matching the style used in modules/amt-wsman.js and modules/amt-xml.js. The original author comment block was preserved unchanged beneath the new header to minimize disruption. π€ Prompt for AI agentsfix confidence: π‘ 80 medium β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_events.h missing Apache 2.0 license header Added the standard Apache License 2.0 header block (with Intel Corporation 2011 copyright and the canonical http://www.apache.org/licenses/LICENSE-2.0 URL) above the existing "linux_events.h" author comment at the top of meshcore/KVM/MacOS/mac_events.h, matching the style used in modules/amt-wsman.js and modules/amt-xml.js. The original author comment block was preserved unchanged beneath the new header to minimize disruption. π€ Prompt for AI agentsfix confidence: π‘ 80 medium β react π/π to teach the reviewer |
||
| * linux_events.h | ||
| * | ||
|
|
@@ -380,3 +403,4 @@ extern void KeyAction(unsigned char vk, int up); | |
| extern void KeyActionUnicode(uint16_t unicode, int up); | ||
|
|
||
| #endif /* LINUX_EVENTS_H_ */ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,17 @@ | ||
| /* | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_kvm.h has a non-standard copyright header instead of the required Apache 2.0/Intel block Replaced the non-standard Xcode-generated placeholder header (lines 1-8, "Copyright 2011 MyCompanyName...") at the top of meshcore/KVM/MacOS/mac_kvm.h with the canonical Intel Apache License 2.0 header block, matching the style used elsewhere in meshcore/microstack/microscript. No other lines were altered. π€ Prompt for AI agentsfix confidence: π‘ 70 medium β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_kvm.h has a non-standard copyright header instead of the required Apache 2.0/Intel block Replaced the non-standard Xcode-generated placeholder header (lines 1-8, "Copyright 2011 MyCompanyName...") at the top of meshcore/KVM/MacOS/mac_kvm.h with the canonical Intel Apache License 2.0 header block, matching the style used elsewhere in meshcore/microstack/microscript. No other lines were altered. π€ Prompt for AI agentsfix confidence: π‘ 70 medium β react π/π to teach the reviewer |
||
| * mac_kvm.h | ||
| * | ||
| * Copyright 2011-2013 Intel Corporation | ||
| * | ||
| * Created by Ylian Saint-Hilaire on 8/17/11. | ||
| * Copyright 2011 __MyCompanyName__. All rights reserved. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| #ifndef LINUX_KVM_H_ | ||
| #define LINUX_KVM_H_ | ||
|
|
@@ -37,3 +44,4 @@ void kvm_cleanup(); | |
|
|
||
| #endif /* LINUX_KVM_H_ */ | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,18 @@ | ||
| /* | ||
| Copyright 2024 Intel Corporation | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
| /* | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_kvm_auth.c missing Apache 2.0 / Intel copyright header Added the standard Apache License 2.0 block comment with Intel Corporation copyright and the canonical license URL at the very top of π€ Prompt for AI agentsfix confidence: π’ 95 high β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_kvm_auth.c missing Apache 2.0 / Intel copyright header Added the standard Apache License 2.0 block comment with Intel Corporation copyright and the canonical license URL at the very top of π€ Prompt for AI agentsfix confidence: π’ 95 high β react π/π to teach the reviewer |
||
| * mac_kvm_auth.c | ||
| * | ||
|
|
@@ -196,3 +211,4 @@ int verify_peer_codesign_audit(int socket_fd) { | |
| #endif | ||
|
|
||
| #endif /* __APPLE__ */ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,18 @@ | ||
| /* | ||
| Copyright 2024 Intel Corporation | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
| /* | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_kvm_auth.h missing required Apache 2.0 license header Added the canonical Apache License 2.0 block comment with Intel Corporation copyright notice immediately before the existing descriptive comment block at the top of meshcore/KVM/MacOS/mac_kvm_auth.h, satisfying MESHAGEN-004-2's requirement without altering any subsequent code, declarations, or the original descriptive comment. π€ Prompt for AI agentsfix confidence: π’ 92 high β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_kvm_auth.h missing required Apache 2.0 license header Added the canonical Apache License 2.0 block comment with Intel Corporation copyright notice immediately before the existing descriptive comment block at the top of meshcore/KVM/MacOS/mac_kvm_auth.h, satisfying MESHAGEN-004-2's requirement without altering any subsequent code, declarations, or the original descriptive comment. π€ Prompt for AI agentsfix confidence: π’ 92 high β react π/π to teach the reviewer |
||
| * mac_kvm_auth.h | ||
| * | ||
|
|
@@ -52,3 +67,4 @@ int codesign_matches(SecCodeRef code1, SecCodeRef code2); | |
| #endif /* __APPLE__ */ | ||
|
|
||
| #endif /* MAC_KVM_AUTH_H */ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,17 @@ | ||
| /* | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_tile.c lacks the required Apache 2.0 license header Replaced the personal/ad-hoc copyright block at the top of π€ Prompt for AI agentsfix confidence: π‘ 85 medium β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_tile.c lacks the required Apache 2.0 license header Replaced the personal/ad-hoc copyright block at the top of π€ Prompt for AI agentsfix confidence: π‘ 85 medium β react π/π to teach the reviewer |
||
| * mac_tile.c | ||
| * | ||
| * Copyright (c) 2011 Intel Corporation | ||
| * | ||
| * Created by Ylian Saint-Hilaire on 8/18/11. | ||
| * Copyright 2011 __MyCompanyName__. All rights reserved. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #include "mac_tile.h" | ||
|
|
@@ -544,3 +551,4 @@ void set_tile_compression(int type, int level) | |
| // TODO Make sure the all the types are handled. We ignore the type variable for now. | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,24 @@ | ||
| /** | ||
| * @description Mac KVM tile handling header | ||
| * @author Ylian Saint-Hilaire | ||
| * @version v0.0.1 | ||
| */ | ||
|
|
||
| /* | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_tile.h missing Apache 2.0 license header Replaced the placeholder creation/copyright comment block at the top of π€ Prompt for AI agentsfix confidence: π‘ 85 medium β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_tile.h missing Apache 2.0 license header Replaced the placeholder creation/copyright comment block at the top of π€ Prompt for AI agentsfix confidence: π‘ 85 medium β react π/π to teach the reviewer |
||
| * mac_tile.h | ||
| * | ||
| * | ||
| * Created by Ylian Saint-Hilaire on 8/18/11. | ||
| * Copyright 2011 __MyCompanyName__. All rights reserved. | ||
| * | ||
| */ | ||
| Copyright 2011 Intel Corporation | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| #ifndef LINUX_TILE_H_ | ||
| #define LINUX_TILE_H_ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,19 @@ | ||
| /* | ||
| Copyright 2024 Intel Corporation | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| #ifndef MAC_AUTHORIZED_INSTALL_H | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_authorized_install.h is missing the required Apache 2.0 license header Added the canonical Apache License 2.0 block comment with the "Copyright 2024 Intel Corporation" line at the very top of π€ Prompt for AI agentsfix confidence: π’ 90 high β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_authorized_install.h is missing the required Apache 2.0 license header Added the canonical Apache License 2.0 block comment with the "Copyright 2024 Intel Corporation" line at the very top of π€ Prompt for AI agentsfix confidence: π’ 90 high β react π/π to teach the reviewer |
||
| #define MAC_AUTHORIZED_INSTALL_H | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,19 @@ | ||
| /* | ||
| Copyright 2006 - 2025 Intel Corporation | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| #ifndef MAC_INSTALL_WINDOW_H | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_install_window.h is missing the required Apache 2.0 license header Added the standard Apache License, Version 2.0 header block (matching the style used in sibling files across meshcore/, microstack/, and microscript/) at the top of meshcore/MacOS/Install_UI/mac_install_window.h, before the existing π€ Prompt for AI agentsfix confidence: π’ 90 high β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_install_window.h is missing the required Apache 2.0 license header Added the standard Apache License, Version 2.0 header block (matching the style used in sibling files across meshcore/, microstack/, and microscript/) at the top of meshcore/MacOS/Install_UI/mac_install_window.h, before the existing π€ Prompt for AI agentsfix confidence: π’ 90 high β react π/π to teach the reviewer |
||
| #define MAC_INSTALL_WINDOW_H | ||
|
|
||
|
|
@@ -43,3 +59,4 @@ InstallResult show_install_assistant_window(void); | |
| #endif | ||
|
|
||
| #endif // MAC_INSTALL_WINDOW_H | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,19 @@ | ||
| /* | ||
| * Copyright (c) Intel Corporation 2017-2024 | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #ifndef MAC_PERMISSIONS_WINDOW_H | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_permissions_window.h missing required Apache 2.0 license header Added the Apache License 2.0 block comment with Intel Corporation copyright notice at the top of π€ Prompt for AI agentsfix confidence: π‘ 80 medium β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_permissions_window.h missing required Apache 2.0 license header Added the Apache License 2.0 block comment with Intel Corporation copyright notice at the top of π€ Prompt for AI agentsfix confidence: π‘ 80 medium β react π/π to teach the reviewer |
||
| #define MAC_PERMISSIONS_WINDOW_H | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,19 @@ | ||
| /* | ||
| Copyright 2006 - 2024 Intel Corporation | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| #include <stdio.h> | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ test_window.c missing required Apache 2.0 license header Added the standard Apache License, Version 2.0 header block with Intel copyright notice ("Copyright 2006 - 2024 Intel Corporation") at the top of π€ Prompt for AI agentsfix confidence: π’ 95 high β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ test_window.c missing required Apache 2.0 license header Added the standard Apache License, Version 2.0 header block with Intel copyright notice ("Copyright 2006 - 2024 Intel Corporation") at the top of π€ Prompt for AI agentsfix confidence: π’ 95 high β react π/π to teach the reviewer |
||
| #include "mac_permissions_window.h" | ||
|
|
||
|
|
@@ -14,3 +30,4 @@ int main(int argc, char* argv[]) { | |
|
|
||
| return 0; | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| /* | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ bundle_detection.c license header uses generic year without Intel Corporation copyright line Changed the license header at the top of π€ Prompt for AI agentsfix confidence: π’ 90 high β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ bundle_detection.c license header uses generic year without Intel Corporation copyright line Changed the license header at the top of π€ Prompt for AI agentsfix confidence: π’ 90 high β react π/π to teach the reviewer |
||
| Copyright 2025 | ||
| Copyright 2025 Intel Corporation | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
|
|
@@ -149,3 +149,4 @@ int adjust_working_directory_for_bundle(void) | |
| } | ||
|
|
||
| #endif /* __APPLE__ */ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| /* | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ meshcore/MacOS/bundle_detection.h uses non-standard copyright header without Intel Corporation line Changed the copyright line in the Apache 2.0 header comment block at the top of meshcore/MacOS/bundle_detection.h from "Copyright 2025" to "Copyright 2025 Intel Corporation", matching the canonical header convention used elsewhere in meshcore/. No other content was modified. π€ Prompt for AI agentsfix confidence: π’ 95 high β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ meshcore/MacOS/bundle_detection.h uses non-standard copyright header without Intel Corporation line Changed the copyright line in the Apache 2.0 header comment block at the top of meshcore/MacOS/bundle_detection.h from "Copyright 2025" to "Copyright 2025 Intel Corporation", matching the canonical header convention used elsewhere in meshcore/. No other content was modified. π€ Prompt for AI agentsfix confidence: π’ 95 high β react π/π to teach the reviewer |
||
| Copyright 2025 | ||
| Copyright 2025 Intel Corporation | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
|
|
@@ -65,3 +65,4 @@ int adjust_working_directory_for_bundle(void); | |
| #endif /* __APPLE__ */ | ||
|
|
||
| #endif /* MACOS_BUNDLE_DETECTION_H */ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,19 @@ | ||
| /* | ||
| Copyright 2025 Intel Corporation | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| /* | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ meshcore/MacOS/mac_logging_utils.c missing Apache 2.0 license header entirely Added the standard Apache License 2.0 block comment with the Intel Corporation copyright line at the top of meshcore/MacOS/mac_logging_utils.c, preceding the existing descriptive comment block, matching the suggested fix text exactly and leaving all other code unchanged. π€ Prompt for AI agentsfix confidence: π’ 90 high β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ meshcore/MacOS/mac_logging_utils.c missing Apache 2.0 license header entirely Added the standard Apache License 2.0 block comment with the Intel Corporation copyright line at the top of meshcore/MacOS/mac_logging_utils.c, preceding the existing descriptive comment block, matching the suggested fix text exactly and leaving all other code unchanged. π€ Prompt for AI agentsfix confidence: π’ 90 high β react π/π to teach the reviewer |
||
| Shared logging utility for macOS components | ||
|
|
||
|
|
@@ -34,3 +50,4 @@ void mesh_log_message(const char* format, ...) { | |
| } | ||
| va_end(args2); | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,21 @@ | ||
| /* | ||
| * Copyright (C) 2024 Intel Corporation | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| #ifndef MAC_LOGGING_UTILS_H | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_logging_utils.h missing required Apache 2.0 license header Prepended an Apache License 2.0 block comment with Intel Corporation copyright and SPDX identifier at the top of meshcore/MacOS/mac_logging_utils.h, before the include guard, resolving the missing license header finding. Confidence is not higher because the exact canonical header text/format and copyright year used elsewhere in the repo's meshcore/ files were not visible to verify an exact match. π€ Prompt for AI agentsfix confidence: π‘ 70 medium β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_logging_utils.h missing required Apache 2.0 license header Prepended an Apache License 2.0 block comment with Intel Corporation copyright and SPDX identifier at the top of meshcore/MacOS/mac_logging_utils.h, before the include guard, resolving the missing license header finding. Confidence is not higher because the exact canonical header text/format and copyright year used elsewhere in the repo's meshcore/ files were not visible to verify an exact match. π€ Prompt for AI agentsfix confidence: π‘ 70 medium β react π/π to teach the reviewer |
||
| #define MAC_LOGGING_UTILS_H | ||
|
|
||
|
|
@@ -19,3 +37,4 @@ | |
| void mesh_log_message(const char* format, ...); | ||
|
|
||
| #endif // MAC_LOGGING_UTILS_H | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,19 @@ | ||
| /* | ||
| Copyright 20XX Intel Corporation | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| /* | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_plist_utils.c missing required Apache 2.0 license header Added the standard Apache License 2.0 block comment with "Copyright 20XX Intel Corporation" at the very top of meshcore/MacOS/mac_plist_utils.c, preceding the pre-existing top-of-file descriptive comment, exactly as suggested in the finding. No other code was modified. π€ Prompt for AI agentsfix confidence: π’ 95 high β react π/π to teach the reviewer
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π΄ mac_plist_utils.c missing required Apache 2.0 license header Added the standard Apache License 2.0 block comment with "Copyright 20XX Intel Corporation" at the very top of meshcore/MacOS/mac_plist_utils.c, preceding the pre-existing top-of-file descriptive comment, exactly as suggested in the finding. No other code was modified. π€ Prompt for AI agentsfix confidence: π’ 95 high β react π/π to teach the reviewer |
||
| Shared plist parsing utilities for macOS | ||
|
|
||
|
|
@@ -225,3 +241,4 @@ int mesh_parse_launchdaemon_plist(const char* plistPath, MeshPlistInfo* info) { | |
|
|
||
| return foundMeshagent; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
𦩠π΄ mac_events.c is missing the required Apache 2.0 / Intel license header
Prepended a standard Apache License 2.0 block comment with the Intel Corporation copyright line at the very top of meshcore/KVM/MacOS/mac_events.c, before the existing
#include "mac_events.h"line, matching the header style used elsewhere in meshcore/ (e.g. meshcore/KVM/Linux/linux_tile.h). No other lines were changed.π€ Prompt for AI agents
fix confidence: π‘ 85 medium β react π/π to teach the reviewer