feat(cli): upload compiled theme fragment and let FDR merge global themes at publish - #17783
Open
Ryan-Amirthan wants to merge 3 commits into
Open
Ryan-Amirthan wants to merge 3 commits into
Ryan-Amirthan wants to merge 3 commits into
Conversation
…emes at publish Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![nitpickybot[bot]](https://avatars.githubusercontent.com/in/2901896?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…elCase theme keys Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Devin Review found 4 potential issues.
2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
… remote-asset themes, map logoRightText Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CLI half of server-side global themes (FDR half: fern-api/fern-platform#14922). Lets a
theme uploadrefresh every site using that theme without republishing each one.Changes Made
fern docs theme uploadalso sendscompiled: { config, fileManifest }— a ledger-shaped fragment built with the existingDocsDefinitionResolver+mapDocsConfigToLedgerConfig; theme assets are namespaced under_theme/.fern docs publish(ledger mode) sends the unmerged config +globalThemewhen the fetched theme has acompiledHash; otherwise (older theme uploads, header/footer themes, legacy deploy) it stitches locally as before.fern docs devunchanged.Testing
compileGlobalTheme.test.ts)Link to Devin session: https://app.devin.ai/sessions/5bd32372fdc3496982d9c6256cb3fcb3
Open in Devin Desktop: https://app.devin.ai/desktop/session/5bd32372fdc3496982d9c6256cb3fcb3?variant=devin
Requested by: @Ryan-Amirthan