Skip to content

Reject invalid extended frame lengths #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OskarEichler wants to merge 1 commit into from
Closed

Reject invalid extended frame lengths #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/websocket/driver/hybi.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,15 @@ def parse_extended_length(buffer)
@frame.length = buffer.unpack(PACK_FORMATS[buffer.bytesize]).first
@stage = @frame.masked ? 3 : 4

if (buffer.bytesize == 2 && @frame.length < 126) ||
(buffer.bytesize == 8 && @frame.length < 65_536)
return fail(:protocol_error, 'Received frame with non-minimal length encoding')
end

if buffer.bytesize == 8 && (buffer.getbyte(0) & MASK) == MASK
return fail(:protocol_error, 'Received frame with invalid 64-bit length')
end

unless MESSAGE_OPCODES.include?(@frame.opcode) or @frame.length <= 125
return fail(:protocol_error, "Received control frame having too long payload: #{ @frame.length }")
end
Expand Down