Show full timestamps in event and stack list tooltips - #2583
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b269f64d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09a85e43ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
09a85e4 to
8741df6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fa067e9c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Time | ||
| {...props} | ||
| class="focus-visible:ring-ring inline cursor-help rounded-sm outline-none focus-visible:ring-2 focus-visible:ring-offset-2" |
There was a problem hiding this comment.
Although the session-events call site now composes the event link as the trigger, fresh repo evidence shows that the main /next/event and /next/stack tables still render this default focusable <time> inside the per-cell link created by data-table-body.svelte:351-359 when rowHref is supplied. The new E2E test even confirms that this inner timestamp receives real Tab focus, so keyboard users encounter both the outer link and this second tab stop, and pressing Enter on the <time> does not activate the event/stack link. Compose the tooltip trigger with the existing cell link for these tables as well, rather than spreading the focusable trigger props onto the nested <time>.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3012b00281
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| </script> | ||
|
|
||
| <Time live={true} relative={true} timestamp={value}></Time> | ||
| <Time format="MMM D, YYYY h:mm:ss A [UTC]Z" live={true} relative={true} timestamp={value}></Time> |
There was a problem hiding this comment.
For keyboard-only users, the full timestamp is still unavailable because this revision now relies solely on a native title, while the <time> is intentionally not focusable and focus remains on the enclosing table link; focusing that link does not display its descendant's native title. Fresh evidence since the earlier finding is the replacement of the composed tooltip with this title-only implementation and the new tests explicitly asserting that the timestamp has no tabindex. Associate the full timestamp with the existing focusable link or otherwise expose it without adding a nested tab stop.
Useful? React with 👍 / 👎.
3012b00 to
34c4b7c
Compare
|
1 participant
Relative timestamps retain their compact label and use a native hover title with the full date, seconds, and time zone.
TimeAgoformats that title with the browser's default locale and time zone, respecting date order, numerals, and clock conventions. It also exposes the full timestamp as visually hidden text for assistive technology. Session events remain plainAwrappingTimeAgo, without an extra tab stop or tooltip configuration.Validation: six unit tests and six local Chromium flows passed, covering US/Los Angeles, British/London, German/Berlin, Japanese/Tokyo, and Arabic/Cairo formatting, accessibility-tree text, and session-link keyboard navigation.
npm run validatepassed. Title formatting is cached until the timestamp changes. Native tooltip interaction remains browser-managed; no full screen-reader or touch-device audit is claimed. Hosted CI is pending. No public API or breaking changes.