Conversation
b22a86a to
db17534
Compare
c3d3fb5 to
9546c7f
Compare
1233eba to
97a1a43
Compare
97c915f to
81599b4
Compare
Guided-tour review update — September 8Head: This pass
Reviewed suggestions intentionally not applied
Verification
The first-day retention and Up/Down failures were missing boundary cases in earlier tests, now covered. Existing dependency advisories on main remain unchanged; this pass adds no dependencies. |
57cb577 to
bf2c3ea
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2ef1ac827
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8bba742ea7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b45ad1a00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77755fff07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f275caae14
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b04f16d842
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0bc4e913a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d34ddf5e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 36ad698501
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bdc37b3deb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 314c669529
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46d4bb62d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 569c0675b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45e21f6b93
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1b66657 to
7566053
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7566053def
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3366be1dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| """; | ||
|
|
||
| await PatchAsync(user.Id, new ScriptPatch(script) |
There was a problem hiding this comment.
When another user mutation begins before this patch and finishes afterward, its whole-document save can erase the newly recorded tour value. For example, UserHandler.Handle(UpdateUserMessage) reads a snapshot at line 196 and replaces it with SaveAsync at line 208; if this patch lands between those operations, the stale ProductTours dictionary is written back, so the completion or invitation acknowledgement disappears and the tour is offered again. Protect this field by merging the latest progress during full saves or by using optimistic concurrency with a retry.
AGENTS.md reference: AGENTS.md:L72-L75
Useful? React with 👍 / 👎.
|
@ejsmith One concurrency concern worth discussing before merging: tour recording uses an atomic If that handler reads the user before a tour is recorded and saves afterward, its stale Would you prefer addressing these existing-user writes with field-level patches as a separate change? Scalar updates could use This is supported by inspection of the current code and installed repository implementation; I have not reproduced it against local Elasticsearch because shared integration testing is paused. Current PR CI is green, but does not cover this interleaving. No persistence changes have been made for this concern. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 455f02da9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 511200b2dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| const next = steps[stepIndex + 1]; | ||
| if (next) { | ||
| productTourCheckpoint.advance(currentCheckpoint, next.checkpointName); |
There was a problem hiding this comment.
When a user follows the interactive Stacks target during the first overview step, the guide remains active on /stack; using Next for the Events step then advances directly to filters without navigating back. Because [data-tour="event-filters"] does not exist on Stacks, the new spotlight clears the checkpoint and tells the user to restart. Navigate to Events when advancing into the route-specific filter step, or otherwise prevent this valid mix of target interaction and Next from terminating the guide.
Useful? React with 👍 / 👎.
| }) | ||
| .catch(() => undefined); | ||
| } | ||
| void submitProductTourActivity(action, checkpoint.tourName); |
There was a problem hiding this comment.
When the browser telemetry import or Exceptionless.submitFeatureUsage rejects—for example because its queue or storage backend fails—this fire-and-forget promise has no rejection handler. The guide has already been cleared, so callers cannot catch it, and the failure becomes an unhandled rejection despite telemetry being intended to remain non-blocking. Attach a rejection handler as is already done for the progress mutation.
Useful? React with 👍 / 👎.
|
Adds five optional guides to the Svelte UI, available from Help and the command palette. Guides advance through successful task actions, retain resumable checkpoints, and persist completion without blocking the user on save failures.
Validation: merged current
origin/main; .NET and frontend builds, frontend validation, and all 872 unit/component tests pass. All 86 browser tests are discoverable; hosted CI for the viewport-resize fix is pending.Reviewer decision: stale whole-user saves can overwrite tour progress. This concern is raised with @ejsmith; no cross-cutting persistence fix is included.
Verification and implementation details
What changed
Adds five optional guides to the Svelte UI, available from Help and the command palette: the app overview, project setup, saved views, error investigation, and Exie.
PUT /api/v2/users/me/product-tours/{tourName}/record. It atomically patches one key, preserves the first timestamp, and limits new keys to 100 entries. Current-user reads return authoritative preferences without stale cache results.Verification
origin/main(252711f6c) into the PR in455f02da9. Frontend validation, production build, and all 872 unit/component tests passed, including rendered catalog checks that Continue preserves the checkpoint on Events, Stacks, and Sessions saved views.d3366be1dpassed API (2,971 tests passed, three skipped), frontend, all 85 Chromium E2E cases with no retries, Docker builds, version, and CLA. This includes all 22 guide cases and the four saved-view navigation regressions.Compatibility
No data migration is required. Existing timestamp keys and unrelated legacy JSON values are preserved; the UI recognizes historical guide names and string completion/dismissal states. Explicitly recording a guide converts an older structured value at that selected key to a timestamp without modifying other keys. Existing public routes and payload formats are unchanged; the record endpoint and current-user field are additive.