Skip to content

refactoring/raise-code-coverage #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redcatbear merged 7 commits into from
Jul 17, 2026
Merged

refactoring/raise-code-coverage #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6af5cef
Raise code coverage.
redcatbear Jul 17, 2026
5c447ea
Added missing overrides.
redcatbear Jul 17, 2026
8727599
Updated changelog entry.
redcatbear Jul 17, 2026
47e91f6
Reformatted file.
redcatbear Jul 17, 2026
3f298f9
#32: Exchanged switch `--db-version` with `--itde-db-version` in slow…
redcatbear Jul 17, 2026
d1c3550
#32: Fixed Exasol version number (should be 2026.1.0).
redcatbear Jul 17, 2026
0a157aa
#32: Exasol 2026.1.0 not covered yet by the ITDE. Reverting to 2025.1…
redcatbear Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/slow-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ jobs:

- name: Run Integration Tests
id: run-integration-tests
run: poetry run -- nox -s test:integration -- --coverage --db-version ${MATRIX_EXASOL_VERSIONS}
# We need to set the backend explicity. Otherwise, integration tests are skipped.
run: poetry run -- nox -s test:integration -- --coverage --backend onprem --itde-db-version ${MATRIX_EXASOL_VERSIONS}
env:
MATRIX_EXASOL_VERSIONS: ${{ matrix.exasol_versions }}

Expand Down
2 changes: 2 additions & 0 deletions doc/changes/unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Summary

In this release we fixed integration test and therefore code coverage reporting in CI. The switch `--backend onprem` was missing from slow tests, causing integration tests to be skipped.

## Security Issues

* #23: Fixed security issues by updating dependencies
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ dynamic = ["classifiers", "dependencies"]

classifiers = [
"Development Status :: 5 - Production/Stable",
"License :: OSI Approved :: MIT License",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
Expand Down
2 changes: 1 addition & 1 deletion test/integration/dialects/exasol/test_exasol_object_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def test_fully_qualified_name(factory):
table = schema.create_table("CREATE_QUALIFIED_NAME_TEST_TABLE", ID="DECIMAL(12,0)")
assert (
table.fully_qualified_name()
== '"CREATE_QUALIFIED_NAME_TEST_SCHEMA"."CREATE_QUALIFIED_NAME_TEST_TABLE"',
== '"CREATE_QUALIFIED_NAME_TEST_SCHEMA"."CREATE_QUALIFIED_NAME_TEST_TABLE"'
)


Expand Down