SWIP-TBA - Chunk checksum for divergent sync#101
Open
acud wants to merge 2 commits into
Open
Conversation
lat-murmeldjur
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This SWIP handles the simplification of the addition of extra information needed in order to have better eventual consistency in a neighborhood. Instead of adding information - we reduce the number of fields. This is obviously a breaking change. The other negative side effect is that we'd have to keep the extra
Sumbytes on the indices in order to avoid an extra chunk lookup for every chunk weOffer. Due to this I suggest to lower theSumlength to8 bytes(32 mb extra data in the specific index for a ~4.1mil chunk reserve. 16 bytes would be 65 megs, none are deal-breakers).