fix: repair pnpm run lint and gate it in CI

[JohnMcLear]

Why

pnpm run lint does not run in this repo. package.json asks for
typescript: ^7.0.2, and TypeScript 7 is the native port: it no longer
exposes the legacy JS compiler API that ts-api-utils (pulled in by
@typescript-eslint) reads at module load. Loading the ESLint config
therefore throws

Cannot read properties of undefined (reading 'Intrinsic')

and the whole lint run dies before a single file is checked. No workflow
ran lint, which is why this rotted unnoticed.

What changed

• typescript pinned to ~6.0.3 — the last major the typescript-eslint
  stack supports.
• eslint-config-etherpad bumped to ^5.0.0. 5.x declares
  typescript: ">=4.8.4 <6.1.0", so the next TypeScript major fails
  loudly at install time instead of silently breaking lint again.
• pnpm-lock.yaml regenerated. The large deletion is just TypeScript 7's
  ~20 per-platform native binaries going away.
• New .github/workflows/lint.yml (reusable, same as
  fix: repair pnpm run lint and gate it in CI ep_cursortrace#117), wired into test-and-release.yml as a
  lint: job and added to the release job's needs: so lint now gates
  releases.

Lint result

pnpm run lint passes after one hand fix: index.js required
ep_etherpad-lite/node/eejs but never used it (ep_plugin_helpers
template() replaced that usage), which tripped no-unused-vars. The
unused require is dropped in its own commit.

12 no-use-before-define / camelcase / you-dont-need-lodash-underscore
warnings remain in static/js/index.js. Warnings do not fail the run and
fixing them would mean reordering/renaming live code, so they are left for
a follow-up.

🤖 Generated with Claude Code

https://claude.ai/code/session_013S4pYSjwUsiZtdtMMpW7bw

[qodo-code-review]

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Repair pnpm lint and gate releases in CI

🐞 Bug fix ⚙️ Configuration changes 🕐 20-40 Minutes

AI Description

• Restores ESLint by aligning TypeScript and Etherpad lint configuration versions.
• Adds reusable lint CI and requires it before release publication.
• Removes a dead import exposed by the repaired lint run.

Diagram

graph TD
  A["Repository push"] --> B["Test workflow"] --> C["Lint workflow"] --> D["Compatible toolchain"] --> E["Run ESLint"] --> F{"Lint passes?"} --> G["Release publication"]

Loading

High-Level Assessment

The selected approach is appropriate: pinning TypeScript to the latest supported major restores the legacy compiler API, while eslint-config-etherpad 5 enforces the compatibility range through peer dependencies. Patching transitive lint packages or adopting unsupported TypeScript 7 APIs would add maintenance risk without improving this repository.

Files changed (5) +304 / -475

Bug fix (1) +0 / -1

index.jsRemove unused Etherpad template import +0/-1

Remove unused Etherpad template import

• Drops the obsolete 'eejs' require now superseded by the plugin helper template API, satisfying the enabled 'no-unused-vars' rule without changing behavior.

index.js

Other (4) +304 / -474

lint.ymlAdd reusable ESLint workflow +35/-0

Add reusable ESLint workflow

• Introduces a reusable GitHub Actions workflow that configures Node.js and pnpm, restores the dependency cache, installs dependencies, and runs the repository lint script.

.github/workflows/lint.yml

test-and-release.ymlRequire linting before releases +4/-0

Require linting before releases

• Invokes the reusable lint workflow from the push pipeline. Adds the lint job to the release dependencies so publication cannot proceed after lint failure.

.github/workflows/test-and-release.yml

package.jsonAlign TypeScript and ESLint configuration versions +2/-2

Align TypeScript and ESLint configuration versions

• Upgrades 'eslint-config-etherpad' to 5.x and pins TypeScript to the supported 6.0 release line. This restores ESLint startup and makes unsupported future compiler upgrades fail peer-dependency validation.

package.json

pnpm-lock.yamlRegenerate the compatible lint dependency graph +263/-472

Regenerate the compatible lint dependency graph

• Locks TypeScript 6.0.3, eslint-config-etherpad 5.0.2, and the updated typescript-eslint ecosystem. Removes TypeScript 7 native platform packages and records the new transitive lint dependencies.

pnpm-lock.yaml

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can turn on the rule miner and Qodo learns your standards from review history

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗