Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: Lint

on:
workflow_call:

jobs:
lint:
name: ESLint
runs-on: ubuntu-latest
# `eslint .` executes .eslintrc.cjs and every installed ESLint plugin, so
# don't hand it the caller's contents:write / id-token:write token.
permissions:
contents: read
steps:
- name: Check out plugin repository
uses: actions/checkout@v7
- uses: actions/setup-node@v7
name: Install Node.js
with:
node-version: 25
- uses: pnpm/action-setup@v6.1.0
name: Install pnpm
with:
version: 10
run_install: false
- name: Get pnpm store directory
shell: bash
run: echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
- uses: actions/cache@v6
name: Setup pnpm cache
with:
path: ${{ env.STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
- name: Install dependencies
run: pnpm install --ignore-scripts
- name: Run ESLint
run: pnpm run lint
4 changes: 4 additions & 0 deletions .github/workflows/test-and-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ permissions:
id-token: write

jobs:
lint:
uses: ./.github/workflows/lint.yml
secrets: inherit
backend:
uses: ./.github/workflows/backend-tests.yml
secrets: inherit
Expand All @@ -23,6 +26,7 @@ jobs:
release:
if: ${{ github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main' }}
needs:
- lint
- backend
- frontend
permissions:
Expand Down
1 change: 0 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

const {template} = require('ep_plugin_helpers');

const eejs = require('ep_etherpad-lite/node/eejs');
const settings = require('ep_etherpad-lite/node/utils/Settings');

exports.loadSettings = (hookName, context, cb) => {
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"email": "john@mclear.co.uk"
},
"engines": {
"node": ">=18.0.0"
"node": ">=22.0.0"
},
"repository": {
"type": "git",
Expand All @@ -19,8 +19,8 @@
},
"devDependencies": {
"eslint": "^8.57.1",
"eslint-config-etherpad": "^4.0.5",
"typescript": "^7.0.2"
"eslint-config-etherpad": "^5.0.0",
"typescript": "~6.0.3"
},
"scripts": {
"lint": "eslint .",
Expand Down
Loading
Loading