fix(deps): move pnpm overrides to pnpm-workspace.yaml - #106
Merged
Merged
Conversation
pnpm 11 no longer reads the `pnpm` field from package.json, so the
overrides added by the recent dependency sweep were silently ignored
while the lockfile still recorded them. The frozen install used by the
publish job then aborts with:
ERR_PNPM_LOCKFILE_CONFIG_MISMATCH
Cannot proceed with the frozen installation. The current "overrides"
configuration doesn't match the value found in the lockfile
which kills the release workflow in its "Bump version (patch)" step, so
the plugin cannot publish at all.
Move the same overrides, unchanged, into pnpm-workspace.yaml where
pnpm 11 reads them. pnpm 10 (used by the lint job) reads them there too,
and lockfileVersion stays at '9.0'.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013S4pYSjwUsiZtdtMMpW7bw
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR |
PR Summary by QodoMove pnpm overrides to workspace configuration
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
The recent dependency sweep added
pnpm.overridestopackage.jsonto clear the js-yaml / brace-expansion advisories, and regenerated the lockfile with pnpm 10.pnpm 11 no longer reads the
pnpmfield from package.json. It warns and ignores it:CI's publish job runs pnpm 11, so it sees no overrides while the lockfile records them, and the frozen install aborts:
The publish job dies in its "Bump version (patch)" step, so this plugin cannot release at all until this is fixed.
The fix
The dependency pins themselves are correct — only their location was wrong. This PR moves them, byte-for-byte unchanged, from
package.jsonintopnpm-workspace.yaml, which both pnpm 10 and pnpm 11 read.Verification
npx -y pnpm@11 i --frozen-lockfile→Done in 388ms using pnpm v11.27.1pnpm i --frozen-lockfilewith pnpm 10.33.0 →Done in 770ms using pnpm v10.33.0lockfileVersion: '9.0'is unchanged, so the lint job (pinned to pnpm 10) still works.js-yaml@4.1.1/brace-expansion@1.1.14anywhere in the lockfile.pnpm run lint→ 0 errors.🤖 Generated with Claude Code
https://claude.ai/code/session_013S4pYSjwUsiZtdtMMpW7bw