Skip to content

Fix quadratic parsing of leading whitespace #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theRizwan wants to merge 1 commit into
base: master
Choose a base branch
from
+28 −4
Open

Fix quadratic parsing of leading whitespace #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/stack-trace-parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ function parseWinjs(line) {
};
}

const geckoRe = /^\s*(.*?)(?:\((.*?)\))?(?:^|@)((?:file|https?|blob|chrome|webpack|rsc|resource|\[native).*?|[^@]*bundle)(?::(\d+))?(?::(\d+))?\s*$/i;
const geckoRe = /^(.*?)(?:\((.*?)\))?(?:^|@)((?:file|https?|blob|chrome|webpack|rsc|resource|\[native).*?|[^@]*bundle)(?::(\d+))?(?::(\d+))?\s*$/i;
const geckoEvalRe = /(\S+) line (\d+)(?: > eval line \d+)* > eval/i;

function parseGecko(line) {
Expand All @@ -93,14 +93,14 @@ function parseGecko(line) {

return {
file: parts[3],
methodName: parts[1] || UNKNOWN_FUNCTION,
methodName: (parts[1] && parts[1].trim()) || UNKNOWN_FUNCTION,
arguments: parts[2] ? parts[2].split(',') : [],
lineNumber: parts[4] ? +parts[4] : null,
column: parts[5] ? +parts[5] : null,
};
}

const javaScriptCoreRe = /^\s*(?:([^@]*)(?:\((.*?)\))?@)?(\S.*?):(\d+)(?::(\d+))?\s*$/i;
const javaScriptCoreRe = /^(?:([^@]*)(?:\((.*?)\))?@)?(\S.*?):(\d+)(?::(\d+))?\s*$/i;

function parseJSC(line) {
const parts = javaScriptCoreRe.exec(line);
Expand All @@ -111,7 +111,7 @@ function parseJSC(line) {

return {
file: parts[3],
methodName: parts[1] || UNKNOWN_FUNCTION,
methodName: (parts[1] && parts[1].trim()) || UNKNOWN_FUNCTION,
arguments: [],
lineNumber: +parts[4],
column: parts[5] ? +parts[5] : null,
Expand Down
24 changes: 24 additions & 0 deletions test/stack-trace-parser.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,30 @@ import * as stackTraceParser from '../src';
import CapturedExceptions from './fixtures/captured-errors';

describe('stackTraceParser', () => {
// `geckoRe` and `javaScriptCoreRe` began with `^\\s*` followed by a group that
// also matches whitespace, so a leading run of spaces could be split between
// them in n ways and parsing a non-matching line was quadratic in its length.
// A 30k-character run took over three seconds; err.stack embeds the message,
// so attacker-influenced text reaches this directly.
it('parses a long leading whitespace run in linear time', function () {
this.timeout(5000);

const time = (n) => {
const line = ' '.repeat(n) + 'x';
const start = Date.now();
stackTraceParser.parse(line);
return Date.now() - start;
};

time(4000); // warm up
const small = time(8000);
const large = time(32000);

// Quadratic would be ~16x for a 4x input; allow generous headroom for a
// slow or noisy CI machine while still failing on the old behaviour.
expect(large).to.be.lessThan(Math.max(small, 1) * 8 + 100);
});

it('parses node error with space in path', () => {
const stackFrames = stackTraceParser.parse(
CapturedExceptions.NODE_SPACE.stack
Expand Down