Skip to content

fix: Reject beta versions older than the latest beta tag #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davseve wants to merge 2 commits into from
Closed

fix: Reject beta versions older than the latest beta tag #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83a1bb2
fix: reject beta versions older than the latest beta tag
davseve Aug 4, 2026
dc5e90f
Merge branch 'main' into fix/ED-24452-reject-older-beta-versions
davseve Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions actions/release-tag-creation/current-version-validation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,16 @@ describe('checkVersionIsNext', () => {
['4.2.0-beta1', '4.2.0-beta2'],
'4.2.0-beta2',
false,
'Expected next beta to be 4.2.0-beta3',
'must be greater than the latest beta tag 4.2.0-beta2',
],
[
'beta',
['4.2.0-beta1', '4.2.0-beta2'],
'4.2.0-beta1',
false,
'must be greater than the latest beta tag 4.2.0-beta2',
],
// beta — next minor / next major
// beta — new version line (must be greater than latest AND beta1)
['beta', ['4.2.0-beta1', '4.2.0-beta2'], '4.3.0-beta1', true, null],
['beta', ['4.2.0-beta1', '4.2.0-beta2'], '5.0.0-beta1', true, null],
[
Expand Down Expand Up @@ -99,6 +106,14 @@ describe('checkVersionIsNext', () => {
false,
'Expected next beta line to be 4.3.0-beta1 or 5.0.0-beta1',
],
// beta — older version line must be rejected (regression)
[
'beta',
['4.2.0-beta1', '4.2.0-beta2'],
'4.1.0-beta1',
false,
'must be greater than the latest beta tag 4.2.0-beta2',
],
Comment on lines +109 to +116
// beta — no existing tags
['beta', ['4.1.0', '4.2.0'], '4.2.0-beta1', true, null],
] as const)(
Expand Down
6 changes: 6 additions & 0 deletions actions/release-tag-creation/current-version-validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ function validateNextBeta(
l: semver.SemVer,
latest: string,
): void {
if (!semver.gt(n, l)) {
throw new Error(
`Version ${version} must be greater than the latest beta tag ${latest}.`,
);
}

const latestBetaNum = Number(String(l.prerelease[0]).replace('beta', ''));
const newBetaNum = Number(String(n.prerelease[0]).replace('beta', ''));
const sameLine =
Expand Down
Loading