Gtk4 prep: Avoid connecting directly to key press event#1731
Draft
jeremypw wants to merge 12 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SearchBar:
Attaching a EventControllerKey to a Gtk.Entry does not work (in Gtk3 at least) as the events are swallowed by the widget regardless of the propgation phase. So we handle the key presses in the existing MainWindow key controller.
Plugins
Similarly key events are swallowed by the source view so we attach a key controller to the window in
hook_window ()This has the advantage of not requiring us to disconnect an deactivation but we have to ensure that only key events directed at the sourceview are processed.Some modification of the handlers was required to avoid accessing Gdk.EventKey and deprecated code such as
event.str