feat: allow to do git commits with a custom user - #58
Conversation
|
Hey @magajh may I ask for a review on this? 😊 |
magajh
left a comment
There was a problem hiding this comment.
LGTM as well, although I haven't had a chance to test it yet. @MaferMazu, did you get a chance to test it?
|
Hey @gabor-boros, I just pushed the fix for the RTD check. Could you please rebase your branch onto main? |
@magajh, I haven't tested execution directly since these inputs are optional and don't break existing behavior. However, @gabor-boros, I ran a quick check through Gemini, and it flagged a potential shell injection risk with direct Recommendation: |
Signed-off-by: Gabor Boros <gabor@opencraft.com>
Signed-off-by: Gabor Boros <gabor@opencraft.com>
bab504f to
a55e17c
Compare
Signed-off-by: Gabor Boros <gabor@opencraft.com>
|
@MaferMazu & @magajh Thank you for the review. I rebased and addressed the comment. However, I want to note that the build.yaml is full of potential shell injection vulnerabilities. As those are unrelated to my change and wouldn't be in scope of this PR, I didn't address those. |
Description
This PR allows Picasso's users to set a custom user and email for the git commit step. The default values of the new inputs are the same as it was assigned earlier, therefore not setting the values result in the same GitHub user and email address as it was before this PR.