feat(repo-cache, repo-policy-sync): support glob repository selection - #33
Merged
Conversation
AlexanderLanin
requested review from
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
September 10, 2026 15:21
There was a problem hiding this comment.
🟡 Changes recommended
Recreate cardinality is validated only after all matched repositories are synchronized, and one diagnostic misrepresents archived-inclusive selection.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds case-sensitive fnmatch repository selection across Repo Cache and Repository Policy Sync.
Changes:
- Expands glob selectors before synchronization.
- Adds unmatched-pattern diagnostics and
--recreatevalidation. - Documents behavior and adds regression tests.
File summaries
| File | Description |
|---|---|
repo_cache/src/sync.py |
Implements pattern expansion and diagnostics. |
repo_cache/src/cli.py |
Updates CLI help. |
repo_cache/tests/test_sync.py |
Tests expansion and errors. |
repo_cache/README.md |
Documents glob selection. |
repo_policy_sync/src/runner.py |
Validates expanded recreate targets. |
repo_policy_sync/src/cli.py |
Updates CLI help. |
repo_policy_sync/tests/test_runner.py |
Tests recreate cardinality. |
repo_policy_sync/tests/test_cli.py |
Tests CLI/TOML forwarding. |
repo_policy_sync/README.md |
Documents pattern syntax. |
repo_policy_sync/docs/reference/configuration.md |
Documents TOML selectors. |
repo_policy_sync/docs/reference/cli.md |
Updates CLI reference. |
repo_policy_sync/docs/how-to/run-a-policy.md |
Adds rollout examples. |
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
MaximilianSoerenPollak
previously approved these changes
Sep 10, 2026
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
Talked about in a call. Seems quiet usefull.
MaximilianSoerenPollak
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Repository Policy Sync could only target exact repository names, which made organization-wide rollouts require a manually maintained allowlist. Supporting stable shell-style patterns lets newly created repositories be included automatically while still surfacing invalid selectors clearly.
What changed
fnmatchpatterns for--repoand TOMLreposvalues.--recreatefrom operating on more than one repository after pattern expansion.Fixes #32