Skip to content

Group similar related config members #600

Description

@WilliamRoebuck

What

Currently the config provides the following methods at the top level:

  • takeComponents
  • takeRunTargets
  • takeInitialRunTarget
  • takeFallbackRunTarget
  • takeAliveSupervision
  • takeWatchdog

The first 4 listed are all properties of run target organisation (responsibility of Graph and ProcessGroupManager, while 5 and 6 are unrelated. PR #522 introduces a wrapper around these members, GraphConfig, to allow PGM and Graph to take only the config relating to their roles without needing 3 extra parameters.

Acceptance Criteria (DoD)

The first 4 accessor methods (takeComponents, takeRunTargets, takeInitialRunTarget, takeFallbackRunTarget) should be replaced with a single one that returns all the information needed to organise run targets

How

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cleanupTasks to cleanup the code

    Type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions