safety_sentinel: Remove generic skeleton / proxy from binding - #1069
Open
bemerybmw wants to merge 1 commit into
Open
safety_sentinel: Remove generic skeleton / proxy from binding#1069bemerybmw wants to merge 1 commit into
bemerybmw wants to merge 1 commit into
Conversation
Since the binding level will soon be type erased, we no longer differentiate between a SkeletonEvent and GenericEvent (and same for the proxy side). Therefore, we can remove these units / components from the binding level.
bemerybmw
marked this pull request as ready for review
September 10, 2026 16:38
bemerybmw
requested review from
LittleHuba,
castler,
crimson11,
hoe-jo and
limdor
as code owners
September 10, 2026 16:38
bemerybmw
enabled auto-merge
September 10, 2026 16:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the binding level will soon be type erased, we no longer differentiate between a SkeletonEvent and GenericEvent (and same for the proxy side). Therefore, we can remove these units / components from the binding level.