Skip to content

SDSTOR-23030 fix backward compatibility #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hooper9973 merged 1 commit into from
Jul 9, 2026
+9 −16
Merged

SDSTOR-23030 fix backward compatibility #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

class HomeObjectConan(ConanFile):
name = "homeobject"
version = "4.2.3"
version = "4.2.4"

homepage = "https://github.com/eBay/HomeObject"
description = "Blob Store built on HomeStore"
Expand Down
23 changes: 8 additions & 15 deletions src/lib/homestore_backend/replication_state_machine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,21 +212,14 @@ ReplicationStateMachine::get_blk_alloc_hints(sisl::blob const& header, uint32_t
switch (msg_header->msg_type) {
case ReplicationMessageType::CREATE_SHARD_MSG:
case ReplicationMessageType::SEAL_SHARD_MSG: {
if (data_size == 0) {
// New log-only format: should not reach here, but handle gracefully.
LOGW("get_blk_alloc_hints called for log-only shard message type={}, shard={}, pg={}", msg_header->msg_type,
msg_header->shard_id, msg_header->pg_id);
return homestore::blk_alloc_hints{};
} else {
// Old format: shard message carried shard header/footer data blocks. Return committed_blk_id
// so HomeStore skips block allocation and data write. Shard on_commit will ignore pbas.
homestore::blk_alloc_hints hints;
hints.committed_blk_id = HSHomeObject::tombstone_pbas;
LOGW("get_blk_alloc_hints called for old shard message type={}, shard={}, pg={}, return committed_blk hint "
"to skip blk allocation",
msg_header->msg_type, msg_header->shard_id, msg_header->pg_id);
return hints;
}
// Old format: shard message carried shard header/footer data blocks. Return committed_blk_id
// so HomeStore skips block allocation and data write. Shard on_commit will ignore pbas.
homestore::blk_alloc_hints hints;
hints.committed_blk_id = HSHomeObject::tombstone_pbas;
LOGW("get_blk_alloc_hints called for old shard message type={}, shard={}, pg={}, return committed_blk hint "
"to skip blk allocation",
msg_header->msg_type, msg_header->shard_id, msg_header->pg_id);
return hints;
}

case ReplicationMessageType::PUT_BLOB_MSG:
Expand Down
Loading