Skip to content

[minor] Time input localization support #2501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jialecl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[minor] Time input localization support #2501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65c7db7
Time input localization support
Jialecl Jul 13, 2026
83b5ad5
Added better support based on format and locale
Jialecl Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions packages/lib/src/time-input/TimeInput.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import preview from "../../.storybook/preview";
import disabledRules from "../../test/accessibility/rules/common/disabledRules";
import DxcContainer from "../container/Container";
import { userEvent, within } from "storybook/internal/test";
import { HalstackProvider } from "../HalstackContext";

export default {
title: "Time Input",
Expand Down Expand Up @@ -100,6 +101,32 @@ const TimeInput = () => {
<Title title="Active" theme="light" level={2} />
<TimeInputExamples />
</ExampleContainer>
<ExampleContainer>
<Title title="Localized time input" theme="light" level={3} />
<HalstackProvider localeTag="fi-FI">
<DxcTimeInput label="Finnish locale" helperText="Helper text" defaultValue={continentalValue} showSeconds />
</HalstackProvider>
<HalstackProvider localeTag="en-US">
<DxcTimeInput label="US locale" helperText="Helper text" defaultValue={value} showSeconds />
</HalstackProvider>
<HalstackProvider localeTag="zh-TW">
<DxcTimeInput
label="Taiwanese locale"
helperText="Helper text"
onChange={(val) => console.log(val)}
showSeconds
/>
</HalstackProvider>
<HalstackProvider localeTag="zh-CN">
<DxcTimeInput
label="Chinese locale with 12-hour format"
helperText="Helper text"
onChange={(val) => console.log(val)}
timeFormat="12"
showSeconds
/>
</HalstackProvider>
</ExampleContainer>
</>
);
};
Expand Down Expand Up @@ -237,6 +264,17 @@ const TimePickerExamples = () => {
/>
</DxcContainer>
</ExampleContainer>
<ExampleContainer>
<Title title="Localized time picker" theme="light" level={3} />
<TimePicker
onPickTime={() => {}}
timeFormat="12"
dayPeriodPosition="before"
id="testId"
tabIndex={0}
showSeconds
/>
</ExampleContainer>
</>
);
};
Expand Down
92 changes: 92 additions & 0 deletions packages/lib/src/time-input/TimeInput.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import DxcTimeInput from "./TimeInput";
import MockDOMRect from "../../test/mocks/domRectMock";
import userEvent from "@testing-library/user-event";
import "@testing-library/jest-dom";
import { HalstackProvider } from "../HalstackContext";

// Mocking DOMRect for Radix Primitive Popover
global.DOMRect = MockDOMRect;
Expand Down Expand Up @@ -265,4 +266,95 @@ describe("DxcTimeInput rendering", () => {
userEvent.keyboard("{5}");
expect(mockOnChange).toHaveBeenCalledWith("12:05:00 AM");
});

it("Time input with finnish locale", () => {
const mockOnChange = jest.fn();
const { getByRole, getAllByText } = render(
<HalstackProvider localeTag="fi-FI">
<DxcTimeInput label="Finnish locale" showSeconds onChange={mockOnChange} />
</HalstackProvider>
);
const button = getByRole("button");
expect(button).toBeTruthy();
userEvent.click(button);
const hourbutton = getAllByText("16");
if (hourbutton[0]) userEvent.click(hourbutton[0]);
expect(mockOnChange).toHaveBeenCalledWith("16.00.00");
const minuteButton = getAllByText("30");
if (minuteButton[0]) userEvent.click(minuteButton[0]);
expect(mockOnChange).toHaveBeenCalledWith("16.30.00");
const secondButton = getAllByText("45");
if (secondButton[1]) userEvent.click(secondButton[1]);
expect(mockOnChange).toHaveBeenCalledWith("16.30.45");
});

it("Time input with taiwanese locale", () => {
const mockOnChange = jest.fn();
const { getByRole, getAllByText } = render(
<HalstackProvider localeTag="zh-TW">
<DxcTimeInput label="Taiwanese locale" showSeconds onChange={mockOnChange} />
</HalstackProvider>
);
const button = getByRole("button");
expect(button).toBeTruthy();
userEvent.click(button);
const amButton = getAllByText("AM")[0];
if (amButton) userEvent.click(amButton);
const hourbutton = getAllByText("07");
if (hourbutton[0]) userEvent.click(hourbutton[0]);
expect(mockOnChange).toHaveBeenCalledWith("AM 07:00:00");
const minuteButton = getAllByText("30");
if (minuteButton[0]) userEvent.click(minuteButton[0]);
expect(mockOnChange).toHaveBeenCalledWith("AM 07:30:00");
const secondButton = getAllByText("45");
if (secondButton[1]) userEvent.click(secondButton[1]);
expect(mockOnChange).toHaveBeenCalledWith("AM 07:30:45");
});

it("Time input with taiwanese locale, but using keyboard to input time", () => {
const mockOnChange = jest.fn();
const { getAllByRole } = render(
<HalstackProvider localeTag="zh-TW">
<DxcTimeInput label="Taiwanese locale" showSeconds onChange={mockOnChange} />
</HalstackProvider>
);
const inputs = getAllByRole("spinbutton");
expect(inputs).toHaveLength(4);
userEvent.tab();
expect(inputs[0]).toHaveFocus();
userEvent.keyboard("p");
expect(inputs[1]).toHaveFocus();
userEvent.keyboard("1");
userEvent.keyboard("2");
expect(inputs[2]).toHaveFocus();
userEvent.keyboard("{3}");
userEvent.keyboard("{4}");
expect(inputs[3]).toHaveFocus();
userEvent.keyboard("{5}");
userEvent.keyboard("{6}");
expect(mockOnChange).toHaveBeenCalledWith("PM 12:34:56");
});

it("Time input with chinese locale, but using time picker", () => {
const mockOnChange = jest.fn();
const { getByRole, getAllByText } = render(
<HalstackProvider localeTag="zh-CN">
<DxcTimeInput label="Chinese locale" timeFormat="12" showSeconds onChange={mockOnChange} />
</HalstackProvider>
);
const button = getByRole("button");
expect(button).toBeTruthy();
userEvent.click(button);
const amButton = getAllByText("AM")[0];
if (amButton) userEvent.click(amButton);
const hourbutton = getAllByText("12");
if (hourbutton[0]) userEvent.click(hourbutton[0]);
expect(mockOnChange).toHaveBeenCalledWith("AM 12:00:00");
const minuteButton = getAllByText("30");
if (minuteButton[0]) userEvent.click(minuteButton[0]);
expect(mockOnChange).toHaveBeenCalledWith("AM 12:30:00");
const secondButton = getAllByText("50");
if (secondButton[1]) userEvent.click(secondButton[1]);
expect(mockOnChange).toHaveBeenCalledWith("AM 12:30:50");
});
});
Loading
Loading