fix: prevent action crashes and reduce SOCKS5 save churn - #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/mobilerun/actionstap and swipe requests from crashing on keyed subscriptingNETunnelProviderManagerconfiguration instead of callingsaveToPreferenceson every connectsocks5://startup is rejected and recommendsocks5h://for TCP-only proxiesValidation
xcodebuild test -project WebDriverAgent.xcodeproj -scheme WebDriverAgentLib -destination 'platform=iOS Simulator,id=72A3381E-2F17-4D03-B6A2-4CB64B8DA86A' -only-testing:UnitTests CODE_SIGNING_ALLOWED=NO— 241 tests passed, 1 skippedWebDriverAgentRunnerTunnelgeneric iOS device build passedWebDriverAgentLib_watchOSgeneric watchOS build passedWebDriverAgentLib_tvOSdevice target build passedRuntime note
The repeated 30–40 connect/disconnect cycle scenario was not rerun after this change because the available physical iPhones were offline. The patch removes redundant preference saves for unchanged configurations; configurations that actually change still persist normally.