Skip to content

fix: prevent action crashes and reduce SOCKS5 save churn - #30

Merged
Timo972 merged 1 commit into
masterfrom
timo/fix-wda-tap-crash-socks5-cycling
Aug 27, 2026
Merged

fix: prevent action crashes and reduce SOCKS5 save churn#30
Timo972 merged 1 commit into
masterfrom
timo/fix-wda-tap-crash-socks5-cycling

Conversation

@Timo972

@Timo972 Timo972 commented Aug 27, 2026

Copy link
Copy Markdown

Summary

  • make request-description redaction accept top-level JSON arrays, preventing /mobilerun/actions tap and swipe requests from crashing on keyed subscripting
  • reuse an unchanged, enabled, disconnected NETunnelProviderManager configuration instead of calling saveToPreferences on every connect
  • explain the UDP ASSOCIATE requirement when plain socks5:// startup is rejected and recommend socks5h:// for TCP-only proxies
  • add regression coverage for array request bodies, configuration comparison, and local-DNS diagnostics

Validation

  • xcodebuild test -project WebDriverAgent.xcodeproj -scheme WebDriverAgentLib -destination 'platform=iOS Simulator,id=72A3381E-2F17-4D03-B6A2-4CB64B8DA86A' -only-testing:UnitTests CODE_SIGNING_ALLOWED=NO — 241 tests passed, 1 skipped
  • WebDriverAgentRunnerTunnel generic iOS device build passed
  • WebDriverAgentLib_watchOS generic watchOS build passed
  • WebDriverAgentLib_tvOS device target build passed

Runtime note

The repeated 30–40 connect/disconnect cycle scenario was not rerun after this change because the available physical iPhones were offline. The patch removes redundant preference saves for unchanged configurations; configurations that actually change still persist normally.

@Timo972
Timo972 merged commit 68989bf into master Aug 27, 2026
44 of 50 checks passed
@Timo972
Timo972 deleted the timo/fix-wda-tap-crash-socks5-cycling branch August 27, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant