chore(deps)(deps): bump egui from 0.35.0 to 0.36.1 - #391
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Bumps [egui](https://github.com/emilk/egui) from 0.35.0 to 0.36.1. - [Release notes](https://github.com/emilk/egui/releases) - [Changelog](https://github.com/emilk/egui/blob/main/CHANGELOG.md) - [Commits](emilk/egui@0.35.0...0.36.1) --- updated-dependencies: - dependency-name: egui dependency-version: 0.36.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Antigravity review (Gemini via Ultra)This PR updates the Blocking issues
Suggestions
Nitpicks
Automated first-pass review by |
doublegate
added a commit
that referenced
this pull request
Aug 18, 2026
… wasm break) (#397) * chore(deps): update the dependency graph; hold egui at 0.35 (upstream wasm break) Consolidates the five open Dependabot PRs. Two are adopted, one is a CI action pin, and three are declined on evidence rather than deferred. ADOPTED. `cargo update` across the whole graph — roughly 80 crates, all semver-compatible, no source changes required: `anyhow` 1.0.103 -> 1.0.104, `cc` 1.4.0 -> 1.4.3, `cpal` 0.18.1 -> 0.18.2, the `futures-*` family 0.3.33 -> 0.3.34, the `icu_*` family 2.2 -> 2.3, `http` 1.4.2 -> 1.5.0, `bstr`, `camino`, `clang-sys`, `darling`, `either` and the rest. Plus `taiki-e/install-action` v2.85.10 -> v2.85.13 at both call sites in `security.yml` (#387). DECLINED, with the reason established by experiment: egui / egui-wgpu / egui-winit 0.35 -> 0.36.1 (#389, #390, #391). `egui-winit` 0.36.1 does not compile for `wasm32-unknown-unknown`, and RustyNES ships a wasm demo. error[E0407]: method `bytes` is not a member of trait `egui::DroppedFile` --> egui-winit-0.36.1/src/dropped_file.rs:19:5 The mechanism, since "blocked upstream" is not a diagnosis. egui 0.36 made `DroppedFile` a trait and split it by target: `bytes_async` on wasm (files can only be read asynchronously in a browser), `bytes` on native. Upstream issue #8354, now closed, is the change that introduced it. `egui-winit`'s `NativeFile` impl provides `path` + `bytes` with NO cfg gate, on a type that holds a `PathBuf` and calls `std::fs::read` — inherently native. On wasm it therefore implements a method the trait does not declare and omits the one it does. Nothing on our side can route around it. `mod dropped_file;` is unconditional in egui-winit's `lib.rs` — not feature-gated, not target-gated — so the module compiles on wasm whatever we do, and the fix belongs upstream (a one-line cfg on the module and its `use`). No release carries it: 0.36.1 is still the newest `egui-winit` on crates.io. `wgpu` is held at 29 for the same reason: `egui-wgpu` 0.35 pins it, so 29 -> 30 cannot land ahead of the egui tier. This confirms rather than assumes the note in `AGENTS.md` (added when the migration was first attempted and parked on `chore/egui-0.36-wgpu-30-blocked`). I re-ran the build instead of trusting it, because a "blocked" note is exactly the kind of claim that silently goes stale — and the useful output of re-checking is the specific method name a future attempt needs, `bytes_async`, rather than a bare verdict. Verified: workspace clippy, all four native feature combinations plus `full`, BOTH wasm32 targets, rustdoc with warnings denied, the `no_std` cross-build, 124 workspace test binaries, and `cargo deny check` (advisories ok, bans ok, licenses ok, sources ok). * docs(deps): record the egui 0.35 hold where the pin lives Review suggestion, taken. The reason egui / egui-wgpu / egui-winit are held at 0.35 was in the commit body and the PR — neither of which anyone reads while editing `Cargo.toml`, which is exactly where the next person (or the next `cargo update --aggressive`) will decide to move them. The comment carries the failing error verbatim, the mechanism (egui 0.36 split `DroppedFile` by target — `bytes_async` on wasm, `bytes` on native — and `egui-winit`'s `NativeFile` impl provides `path` + `bytes` with no cfg gate, so on wasm it implements a method the trait does not declare and omits the one it does), why nothing on our side can route around it (`mod dropped_file;` is unconditional in egui-winit's `lib.rs`), and how to re-check: bump it and run both wasm clippy invocations. `wgpu`'s 29 pin gets a line saying it is a consequence of the egui tier rather than anything wgpu did. No dependency change; comments only. * chore(deps): hold the egui tier in dependabot.yml, not only in a comment Review made the point that matters: a comment in `Cargo.toml` explains why the pin exists, and Dependabot cannot read it. It would keep re-opening the same three PRs every Monday. The risk is not the noise. It is that the twentieth identical `bump egui from 0.35.0 to 0.36.x` gets merged on the assumption it is routine -- which is exactly how a pin with a real reason behind it gets undone. `ignore` entries for egui, egui-wgpu, egui-winit (`>=0.36`) and wgpu (`>=30`), carrying the failing error and the mechanism, and saying plainly that this is a HOLD and not a policy: remove all four once upstream ships the one-line cfg, and re-check by bumping and running both wasm clippy invocations. Also raised: whether the `ureq` update pulling in `base64` 0.23.1 alongside the existing 0.22.1 would trip `cargo deny`'s duplicate-version check. Verified rather than assumed -- `cargo deny check` reports `advisories ok, bans ok, licenses ok, sources ok`.
Contributor
Author
|
Looks like egui is no longer being updated by Dependabot, so this is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps egui from 0.35.0 to 0.36.1.
Release notes
Sourced from egui's releases.
... (truncated)
Changelog
Sourced from egui's changelog.
... (truncated)
Commits
4c1f2faRelease 0.36.1 - FixSense::dragbug42cd821FixSense::dragdetecting drags when clicking widget above it (#8396)2397194Release 0.36.0 - Improved mobile keyboard support (#8390)e37d44aNever run an egui pass when nothing will be shown (#8387)90e0302Fix a few nightly clippy lints (#8388)5347b0aFix window with aGridbeing widenable but not shrinkable again (#8386)622bbbeAdd drag-to-open for collapsible panels (#8363)98eab50Treat a press that leaves a widget as a drag (#8365)78c0e39Fix ScrollArea failure by handling horizontal and vertical scrolling separate...5c0b690Addextra_text_line_spacingto control vertical spacing between text lines ...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)