[main] Source code updates from dotnet/dotnet#20043
Open
dotnet-maestro[bot] wants to merge 6 commits into
Open
[main] Source code updates from dotnet/dotnet#20043dotnet-maestro[bot] wants to merge 6 commits into
dotnet-maestro[bot] wants to merge 6 commits into
Conversation
No dependency updates to commit [[ commit created by automation ]]
Contributor
Author
|
Note VMR PRs included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Contributor
✅ No release notes required |
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
The backflowed NuGet.config now defines an <auditSources> entry, which enables NuGet vulnerability auditing. This surfaced NU1903 (treated as an error via TreatWarningsAsErrors) for the vulnerable transitive packages System.Net.Http 4.3.0 and System.Text.RegularExpressions 4.3.0, which are pulled in only by the test dependency graph and are runtime-provided on modern target frameworks. Suppress just these two advisories for test projects via NuGetAuditSuppress, keeping auditing active everywhere else. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The per-advisory NuGetAuditSuppress approach was brittle: after suppressing System.Net.Http/System.Text.RegularExpressions, auditing surfaced a fresh batch of advisories on MessagePack 2.5.198 in FSharp.Compiler.LanguageServer.Tests. Since the backflowed NuGet.config enables auditing for all these test-only, runtime-provided transitive packages, downgrade NU1901-NU1904 from errors to warnings for test projects instead. Findings stay visible; TreatWarningsAsErrors no longer fails the test build. Scoped to tests/ only; product projects keep audit-as-error. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The previous WarningsNotAsErrors attempt did not take effect in CI: NuGet restore does not honor WarningsNotAsErrors for restore-time audit warnings, so NU1903 still failed the build (System.Net.Http / System.Text.RegularExpressions). NuGet restore does reliably honor NoWarn. Suppress NU1901-NU1904 via NoWarn in tests/Directory.Build.props so all test-only, runtime-provided transitive packages (System.Net.Http, System.Text.RegularExpressions, MessagePack, etc.) stop failing the build. Scoped to test projects; product projects keep audit-as-error. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Associated changes in source repos
Diff the source with this PR branch