Skip to content

[release/8.0] Scope WebSocket request-body assertion to in-process hosting #69327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wtgodbe wants to merge 1 commit into
base: release/8.0
Choose a base branch
from
Open

[release/8.0] Scope WebSocket request-body assertion to in-process hosting #69327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Servers/IIS/IIS/test/testassets/InProcessWebSite/Startup.WebSockets.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,13 @@ private static async Task<WebSocket> Upgrade(HttpContext context)

// Upgrade the connection
Stream opaqueTransport = await upgradeFeature.UpgradeAsync();
Assert.Null(context.Features.Get<IHttpMaxRequestBodySizeFeature>().MaxRequestBodySize);

// In-process reads upgraded data through the same loop that enforces MaxRequestBodySize, so it
// must clear the limit. Out-of-process runs on Kestrel, which never enforces it once upgraded.
if (context.Features.Get<IServerVariablesFeature>() is not null)
{
Assert.Null(context.Features.Get<IHttpMaxRequestBodySizeFeature>().MaxRequestBodySize);
}

// Get the WebSocket object
var ws = WebSocket.CreateFromStream(opaqueTransport, isServer: true, subProtocol: null, keepAliveInterval: TimeSpan.FromMinutes(2));
Expand Down
Loading